Closed Bug 1094559 Opened 5 years ago Closed 5 years ago

Dynamic input definition registry in System app (Gaia part of bug 936724)


(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Not set



tracking-b2g backlog


(Reporter: timdream, Assigned: timdream)



(Whiteboard: [FT:System-Platform])


(1 file)

We would need to implement a backend to that Gecko API in System app, so that registered inputs is properly kept in the mozSettings.

Currently mozApp registry is the only source of truth for KeyboardHelper to answer "what's the available/enabled input for type X". With this bug it would have to take dynamic input definitions stored in mozSettings into considerations.

There will be another script added into System along to serve as the backend.
blocking-b2g: --- → backlog
Component: DOM: Device Interfaces → Gaia::System
Product: Core → Firefox OS
Whiteboard: [FT:System-Platform]
Version: Trunk → unspecified
Component: Gaia::System → Gaia::System::Input Mgmt
Comment on attachment 8524340 [details] [review]
mozilla-b2g:master PR#26218

This script is useless (and harmless) without bug 936724 in Gecko, so it's safe to land first.
Attachment #8524340 - Flags: review?(jlu)
Comment on attachment 8524340 [details] [review]
mozilla-b2g:master PR#26218

The patch actually looks fine for me, but I'd like convert the request to f+ as the Gip tests are all failing with keyboard-related errors.

Could actually be the case that it's just the test environment being quirky -- the dynamic_input_registry_test is also failing, which frankly is pretty impossible judging from the code.  

If further retriggers turn out to be green, feel free to r+ by yourself ;)
Attachment #8524340 - Flags: review?(jlu) → feedback+
Comment on attachment 8524340 [details] [review]
mozilla-b2g:master PR#26218

It turn out I push the change that wrapped the function in it's own closure without expose it! This is fixed.

I also made some non-trivial changes on settings handling so we could use the same lock for get and set. Please review that part.
Attachment #8524340 - Flags: review?(jlu)
Comment on attachment 8524340 [details] [review]
mozilla-b2g:master PR#26218

Looks pretty good (Y). Nice work!

I did not look very detailedly into your Gecko patch at bug 936724 to make sure if your JS conforms to everything out there, though.
Attachment #8524340 - Flags: review?(jlu) → review+
Closed: 5 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.