109463 - Submitting a form by pressing enter drops fields[form sub]

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[William Garrison]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.4) Gecko/20010913
BuildID:    2001091303

If you execute a search using this e*Bay form, clicking the "Search" button is
successful.  If you press Enter then Mozilla submits the fields from the
previous form submission, or blank if this is the first time.

Reproducible: Always
Steps to Reproduce:
1.Go to http://pages.ebay.com/search/items/search.html
2.Enter something into the search title.  Ex. "ski pants"
3.Press Enter

Actual Results:  A blank form is submitted.  eBay will return to you the generic
page for an empty search.

Expected Results:  Mozilla should have posted the specified form parameters.

1) This form works in IE5.
2) If you press the "Search" button it works.
3) Additional test:
  1.Initiate a search by clicking the "search" button as above.
  2.Notice that e*Bay tells you what your search string was.  Click back.
  3.Modify the search and hit Enter (don't press "search")
  4.Notice that e*Bay still indicates the same search as before.

Comment 1

[Alexandru Savulov]

confirmed

Comment 2

[Alexandru Savulov]

Attachment: test case that illustrates the problem - ENTER does not trigger onClick for the submit button

This test case is the reduced version of what is to see on search.ebay.com.
The problem is that the submit button has a onClick attribute that calls a
needed javascript function. The ENTER key does not trigger onClick.

IE triggers onClick for the submit button also when ENTER is pressed in one of
the form's fields.

--> event handling

Comment 3

[Alexandru Savulov]

to event handling

Comment 4

[Madhur Bhatia]

with the testcase provided --
1. I see the bug when I enter some search text in query 2, hit enter from the 
textbox field.

2. After entering search text in query 2, if i tab to the submit button or click 
on it, the search string is submitted sucessfully.

with the url provided http://pages.ebay.com/search/items/search.html
1. i enter search string in the 1st search box on the top right of the page and 
hit enter without tabbing to the submit button - the search string is submitted 
successfully.

2. i enter search string in the 'Search title' text box and hit enter - i see 
the bug

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 114383 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 115780 has been marked as a duplicate of this bug. ***

Comment 7

[Johnny Stenback (:jst)]

John, does this sound related to your form submission changes?

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

As per bug 115780 and Alex's comments, this is caused by the onClick() of the
submit button for the form not being run if you hit return in the form.  IE runs
this JS.  It makes sense, since hitting return is the equivalent of hitting the
submit button.

Fix that, and this bug is solved.  Please....

OS All, platform all, adding Brendan and rods.  Is this really "event handling",
BTW?  I'd think it was forms or maybe some part of JS.

Comment 9

[Alexandru Savulov]

was John's change in the form submission already included in that version?

see the first comment:

User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.4) Gecko/20010913

Comment 10

[Brendan Eich [:brendan]]

rjesup: there's no JS involvement, the core engine does not know or care about
things like enter-in-textfield and submit onclick.  I agree this is more of a
form bug than an event one, though -- jst, anyone: shouldn't this go to someone
other than joki?

/be

Comment 11

[John Keiser (jkeiser)]

Yes.  HTML Form Controls.  The problem is almost certainly that we are not
calling the right function or set of functions when ENTER is pressed.

My changes landed on 10/31, though and if that build ID is right we've been
doing this since 0.9.4. (!)  Strange, I didn't think the press-ENTER-to-submit
patch went in 'til 0.9.5, but I could easily be wrong.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

So if it's form controls, I guess it should be reassigned to the owner of that
(rods?)  Reassigning to default owner/QA for form controls since the component
was already changed.

Comment 13

[rods (gone)]

->>

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: More comprehensive testcase

Comment 15

[Boris Zbarsky [:bzbarsky]]

The behavior of IE5 and IE6 (as tested on that testcase) is as follows:

1)  If the form contains only one text (password) input, simply submit the form on
    enter in that text (password) input.  Submit buttons (if any) are _not_ sent
    in the form data that is sent to the server.

2)  If the form contains 2 or more text (password) inputs, trigger the submit
    button.  This means that the submit button's onclick event is fired (before
    the form's onsubmit) and the submit button value is sent to the server.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Passes the testcases in this bug, as well as the testcase in bug 99210 (so no
regressions).

Rod, would you review?

Comment 17

[Boris Zbarsky [:bzbarsky]]

er, bug 99920, not bug 99210.

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 64976 [details] [diff] [review]
Proposed patch

r=[e-mail] (for whatever it's worth; I've hacked on forms some for
<select>)

Comment 19

[John Keiser (jkeiser)]

Comment on attachment 64976 [details] [diff] [review]
Proposed patch

I concur with that assessment if it's worth any more :)  r=jkeiser

Comment 20

[Johnny Stenback (:jst)]

Comment on attachment 64976 [details] [diff] [review]
Proposed patch

sr=jst

Comment 21

[Alexandru Savulov]

ressigning

Comment 22

[rods (gone)]

I haven't applied the patch and tested it, but it looks right. r=rods

Comment 23

[Boris Zbarsky [:bzbarsky]]

checked in.

Comment 24

[Vladimir Ermakov]

verifying on build 2002-01-28-03-trunk on windows 98
and on 2002-01-28-08-trunk on RedHat Linux 6.2