Closed
Bug 1094631
Opened 10 years ago
Closed 9 years ago
[e10s] "Send Tab to Device" add-on does not work with e10s
Categories
(Firefox :: Extension Compatibility, defect)
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
e10s | - | --- |
People
(Reporter: jonathand131, Unassigned)
References
()
Details
(Keywords: addon-compat)
Hello, The "Send Tab to Device" add-on does not work with e10s enabled: when right clicking in a page, the context menu does not have the "Send tab to device" option. When disabling e10s, this option comes back. Tested with firefox-trunk package from http://ppa.launchpad.net/ubuntu-mozilla-daily/ppa/ubuntu, version 36.0~a1~hg20141101r213438-0ubuntu1~umd1~precise on Ubuntu 12.04.5 LTS. Also, this add-on does not appear on the page http://arewee10syet.com/
Reporter | ||
Updated•10 years ago
|
Blocks: e10s-addons
Keywords: addon-compat
Comment 1•10 years ago
|
||
Gregory or Jonathan, can the "Send Tab to Device" add-on actually send tabs to devices, regardless of whether e10s is enabled or not? I seem to recall that this add-on is incompatible with the current version of Firefox Sync.
Flags: needinfo?(gps)
Reporter | ||
Comment 2•10 years ago
|
||
I didn't realized that this add-on was broken even without e10s. Without e10s, using the "Send to device" option from the context menu displays a message box "Please configure sync".
Comment 3•10 years ago
|
||
Thanks for reporting this bug, Jonathan. Since the "Send Tab to Device" add-on itself doesn't work with the new "Firefox Accounts" Sync (even without e10s), I'm going to close this bug report. If gps updates this add-on to work with Firefox Accounts, then he will need to add e10s support then. :)
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(gps)
Resolution: --- → INVALID
Comment 4•10 years ago
|
||
I'm not sure if this is correct, because the add-on works great for me in non-e10s mode. Didn't test in e10s though because a lot of my other add-ons are having problem with that, but if its needed I'll happily help.
Comment 5•10 years ago
|
||
Thanks, Johannes. If you are using Firefox Nightly, you can quickly test whether an add-on works in e10s by just opening a new e10s window (from the File menu or "hamburger" toolbar menu) without restarting the browser.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: INVALID → ---
Comment 6•10 years ago
|
||
Wow, dunno how I could forget that... Probably because Classic Theme Restorer doesn't show that option. Well, I can confirm the behavior Jonathan described, but I didn't test without e10s after, but before & after. 1. Non-e10s Send Tab to Device works great 2. Open e10s window -> Sent Tab to Device shows "You need to configure e10s sync" 3. After doing that even in the non-e10s window the Add-On shows the same message. Need to test if that resolves itself after a restart or if that's somehow stuck now...
Comment 7•10 years ago
|
||
Closing the e10s window doesn't resolve it, gonna restart...
Comment 8•10 years ago
|
||
Restarting and re-installing the add-on also don't help. Tested enforcing a Sync-Now and sync itself still works (checked about:sync-log).
Comment 9•10 years ago
|
||
Comment #6 correction: "You need to configure e10s sync" -> "You need to configure Firefox sync".
Comment 10•10 years ago
|
||
Checked the source: https://github.com/mozilla-services/firefox-send-tab-to-device/blob/master/lib/main.js You can see it prints out "You need to configure Firefox sync" if 'labels.length <= 1', which indeed means 'clientsEngine._store._remoteClients' is empty. I ran this JSON.stringify(Weave.Service.clientsEngine._store._remoteClients); in the Browser Console and it returned an empty set. Does the local sync data get corrupted after using e10s??
Comment 11•10 years ago
|
||
Even after multiple successful synchronizations the data doesn't get corrected. Maybe this isn't even an add-on bug, but just enabling e10s once corrupts these data. Someone could try to do a JSON.stringify(Weave.Service.clientsEngine._store._remoteClients); on a clean, synchronized profile that has remote clients and then open an e10s window and run it again.
Comment 12•10 years ago
|
||
I'm not at my desktop for the weekend, so I tried to reproduce the bug with my laptop but somehow wasn't able to (add-on seems to work in e10s there). I'm a little bit confused though: Jonathan states in comment #1 "when disabling e10s the option comes back" but in comment #2 the add-on doesn't work in non-e10s.
Comment 13•10 years ago
|
||
:gps Is the "Send Tab to Device"-Add-On expected to work with e10s or not? Are there plans to update it / is it still supported, or is an integration into the Firefox Sync Component planned for the future? If support should be continued for this add-on, do you have any idea why it isn't working in e10s in some cases? Thank you in advance. - Correction of comment #12: It seems Jonathan didn't even see the "Send Tab to Devices" entry in the context menu under e10s, but as he switched back to non-e10s the context menu entry re-appeared but was showing the given error message. May be the same as I'm experiencing on my desktop, just that he didn't test before enabling e10s, the only difference being the visibility of the context menu entry under e10s (which was always visible for me).
Flags: needinfo?(gps)
Comment 14•10 years ago
|
||
Send Tab to Device should ideally work with e10s. No clue if it does: I have e10s disabled because too many of my add-ons aren't working yet :/ There might be a compatibility problem with this add-on and classic sync vs Firefox Accounts sync. I wouldn't be surprised if it only worked with classic sync. I've been out of the Firefox Sync game for over a year and don't know how FxA Sync works. I'm not really maintaining this extension. I'll incorporate patches if they are sent to me and push new releases to AMO. Don't expect me to fix this myself.
Flags: needinfo?(gps)
Reporter | ||
Comment 15•10 years ago
|
||
(In reply to Johannes Pfrang [:johnp] from comment #13) > ... > > Correction of comment #12: It seems Jonathan didn't even see the "Send Tab > to Devices" entry in the context menu under e10s, but as he switched back to > non-e10s the context menu entry re-appeared but was showing the given error > message. May be the same as I'm experiencing on my desktop, just that he > didn't test before enabling e10s, the only difference being the visibility > of the context menu entry under e10s (which was always visible for me). Hi All, After migration from Stable to Nightly, I have enabled e10s and have found that this addon doesn't work: the option didn't even show in the context menu (I didn't test between nightly installation and e10s activation). I have then disabled e10s and saw the option come back but was not properly working ("You need to configure Firefox sync" message described in comment #2). As of today, I have e10s enabled and the addon works fully: when I use the "Send this page to device..." option in the context menu, I am offered to choose between my devices and the page is well received on my selected device. Current version: 36.0~a1~hg20141126r217518-0ubuntu1~umd1~precise The addon version is still 0.6.
Comment 16•10 years ago
|
||
Hey Jonathan, Did you use another Sync-Device in between? I experienced the same and it happened after using my laptop for a couple days. Although I'm not sure how this is related in any way...
Reporter | ||
Comment 17•10 years ago
|
||
Yes, I use other devices with sync enabled and various version of Firefox (stable, beta, nightly).
Comment 18•9 years ago
|
||
This appears to be working now. Just tested sending a tab to one of my other devices and it received it without issue. Ubuntu 15.04 on Linux (Ubuntu).
Comment 19•9 years ago
|
||
Yes, seems to be working now.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•