1094636 - "YouTube High Definition" addon resizes YouTube videos smaller than video player starting with Firefox 34

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: Firefox_33_screenshot.jpg

STR:
1. Install "YouTube High Definition" addon: https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/
2. Load any YouTube video and resize the window.

RESULT:
The video becomes smaller than the video player. Please see the attached screenshots. I don't see

This is a regression in Firefox 34. I bisected the regression to the following mozilla-inbound pushlog on 2014-09-02:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3805d7d9a02d&tochange=372ce1f36116

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Firefox_34_screenshot.jpg

Comment 2

[Baris Derin]

@Chris, is it happening for HTML5 player of Flash player?

Comment 3

[Chris Peterson [:cpeterson]]

I'm using YouTube's HTML5 player. Is there a way to force YouTube to use the Flash player?

I tried bisecting the Firefox regression further by testing local builds. The following merge changeset (from fx-team to mozilla-central) *seems* to be the regression, but I'm don't know why.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfeddb24df7e

Comment 4

[Baris Derin]

You can force Flash Player with another add-on of mine.

https://addons.mozilla.org/en-US/firefox/addon/youtube-flash-video-player/

As a side note, during tests I found Electrolysis crashes or gets unresponsive with Flash Player on Nightly.

Comment 5

[Chris Peterson [:cpeterson]]

The resize problem only affects the HTML5 Player.

btw, YouTube High Definition's "don't autoplay" feature works with the Flash Player in Firefox 33, but not Nightly 36. I haven't bisected the regression any further.

Comment 6

[Baris Derin]

Thanks Chris for the feedback. I will test the bug.

I think YouTube is about to change its interface ans scripts in a few days. I am also getting some HTML5 related bug reports. 

YouTube partially release the changes to just some part of the world and gradually propagate the revision to the rest of the world if there are no issues. I will fix it as soon as the changes gets to my end. I will feedback.

Comment 7

[Baris Derin]

Does this still apply? You may want to close this bug, imho.

Comment 8

[Chris Peterson [:cpeterson]]

Baris, I can still reproduce this "video is too small" problem when I enable e10s in Firefox Nightly 50.

Comment 9

[Chris Peterson [:cpeterson]]

If I disable e10s (by unchecking Preferences > Enable multi-process Nightly), then the problem goes away.

Comment 10

[Andrew Overholt [:overholt]]

What are we doing about tracking e10s+addons issues?

Comment 11

[Erin Lancaster [:elan]]

Shell: ^

Comment 12

[:shell escalante]

this is one of the 83 that we didn't triage yet as they were older (verifying still valid) or more add-on specific.  i'm going through and grouping by add-on now and it will just be part of our weekly 45 minutes.

it's down from the 168 we started out with... so just whittling it down every week.

Comment 13

[:shell escalante]

280,000 users according to arewee10syet.com

Comment 14

[Andrew Overholt [:overholt]]

Is there something the add-on needs to change?

Comment 15

[Chris Peterson [:cpeterson]]

WFM in Beta 49 and Nightly 51 on Windows 10 and OS X 10.11.