Closed Bug 1094781 Opened 11 years ago Closed 11 years ago

[Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S9 (21Nov)
Tracking Flags:
Tracking Status
b2g-v2.2 --- verified

People

(Reporter: paco, Assigned: paco)

Details

Attachments

(4 files, 3 obsolete files)

Visual Spec. Call on hold.
241.78 KB, image/png
Details
patch in github
46 bytes, text/x-github-pull-request
gtorodelvalle
: review+
Details | Review
onhold-opacity.png
242.72 KB, image/png
Details
verified_2.2.3gp
1.12 MB, video/3gpp
Details
The ended calls are red, the on hold calls have a opacity.
Assignee: nobody → pacorampas
Summary: [Dialer][Callscreen] The call on hold shouldn't be red → [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
Status: NEW → ASSIGNED
Here's the Call on Hold visual spec. Thanks!
Attached file patch in github (obsolete) —
Attachment #8519883 - Flags: review?(drs.bugzilla)
Comment on attachment 8519883 [details] [review] patch in github Redirecting to Germán.
Attachment #8519883 - Flags: review?(drs.bugzilla) → review?(gtorodelvalle)
Comment on attachment 8519883 [details] [review] patch in github Hi Paco, I included a couple of comments in the PR ;) You'll notice this patch is more about cleaning up than updating code :p Please, set a new r? whenever a new version of the patch is available, please ;) Thanks!
Attachment #8519883 - Flags: review?(gtorodelvalle) → review-
Attached file patch in github —
Attachment #8519883 - Attachment is obsolete: true
Attachment #8522821 - Flags: review?(gtorodelvalle)
Comment on attachment 8522821 [details] [review] patch in github Hi Paco! Looking awesome ;) It was hurting our eyes that red header :p Thank you very much!
Attachment #8522821 - Flags: review?(gtorodelvalle) → review+
BTW, Paco and just not to forget about it ;) Would you be so kind to include a demo of this patch at https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.1-S9#Demos , please ? Thank you very much!
Flags: needinfo?(pacorampas)
merged: ddf5b92f43ec27c93ad4fea4fd1207da8936b8e7 I'm going to upload the demo soon. Thanks German.
Flags: needinfo?(pacorampas)
Sorry, it is only to mark the flag resolved. I forgot in the previous comment. merged: ddf5b92f43ec27c93ad4fea4fd1207da8936b8e7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
Attached image onhold-opacity.png (obsolete) —
Attached image onhold-opacity.png (obsolete) —
Attachment #8524351 - Attachment is obsolete: true
Attached image onhold-opacity.png —
Attachment #8524355 - Attachment is obsolete: true
This bug has been verified as "pass" on latest Nightly build of Flame v2.2 by the STR in Comment 0. Actual results: The call on hold will not be red. See attachment: verified_v2.2.3gp Reproduce rate: 0/10 Device: Flame v2.2 (Verified) Build ID 20150630162500 Gaia Revision bd386f346eb1591fddbc84bf034b22700e7e2a58 Gaia Date 2015-06-30 15:53:15 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150630.200238 Firmware Date Tue Jun 30 20:02:49 EDT 2015 Bootloader L1TC000118D0 Note: On latest Flame master, the call on hold is also not red.
Status: RESOLVED → VERIFIED
status-b2g-v2.2: fixed → verified
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: