POST /rooms/{token} with action refresh, returns 410, rather than 401 if the authentication header is missing

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?][loop-server 0.14])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Experimenting with the POST /rooms/{token} call whilst implementing the standalone client rooms. I found an issue with refresh. I'd forgotten to put the Authentication error in, but rather than an authentication failure, I got:

"Server error" "HTTP 410 Gone" Object { code: 410, errno: 111, error: "Participation has expired." }

If I have an invalid session token in the Authentication header, then I get a 401.
(Reporter)

Updated

4 years ago
Component: Client → Server
QA Contact: anthony.s.hughes
Created attachment 8525951 [details] [review]
Link to GitHub PR.
Attachment #8525951 - Flags: feedback?(standard8)
I have written the following test without being able to reproduce the problem you are facing.
Can you look at my test and see what I missed?
Flags: needinfo?(standard8)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8525951 [details] [review]
Link to GitHub PR.

The test looks fine - I just retested it locally with 0.13.2 and its working fine now.

My guess is that the bug that we initially had where refresh wasn't properly acted upon for the standalone non-hawk refresh fixed this.

Still might be worth landing the test though.
Flags: needinfo?(standard8)
Attachment #8525951 - Flags: feedback?(standard8) → feedback+
> Still might be worth landing the test though.
Yes definitely.
https://github.com/mozilla-services/loop-server/commit/5cb917cab11f56acafede93f849d76b716eece29
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [qa?][loop-server 0.14]
You need to log in before you can comment on or make changes to this bug.