1094998 - POST /rooms/{token} with action refresh, returns 410, rather than 401 if the authentication header is missing

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Mark Banner (:standard8)]

Experimenting with the POST /rooms/{token} call whilst implementing the standalone client rooms. I found an issue with refresh. I'd forgotten to put the Authentication error in, but rather than an authentication failure, I got:

"Server error" "HTTP 410 Gone" Object { code: 410, errno: 111, error: "Participation has expired." }

If I have an invalid session token in the Authentication header, then I get a 401.

Comment 1

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

Comment 2

[Rémy Hubscher (:natim)]

I have written the following test without being able to reproduce the problem you are facing.
Can you look at my test and see what I missed?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8525951 [details] [review]
Link to GitHub PR.

The test looks fine - I just retested it locally with 0.13.2 and its working fine now.

My guess is that the bug that we initially had where refresh wasn't properly acted upon for the standalone non-hawk refresh fixed this.

Still might be worth landing the test though.

Comment 4

[Rémy Hubscher (:natim)]

> Still might be worth landing the test though.
Yes definitely.

Comment 5

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/5cb917cab11f56acafede93f849d76b716eece29