Closed
Bug 1095151
Opened 10 years ago
Closed 10 years ago
[mozinstall] Don't show finder window when installing a dmg on mac
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
756 bytes,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8518493 -
Flags: review?(hskupin)
Updated•10 years ago
|
OS: All → Mac OS X
Comment 2•10 years ago
|
||
Philipp, what is -nobrowse doing? I cannot find any reference for this option. Also please do a try run, so we can see it doesn't regress something. Thanks
Assignee | ||
Comment 3•10 years ago
|
||
-nobrowse: render any volumes invisible in applications such as the OS X Finder. See https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man1/hdiutil.1.html Here is the try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1120b681651c
Comment 4•10 years ago
|
||
Comment on attachment 8518493 [details] [diff] [review] mozinstall-nobrowse.diff Review of attachment 8518493 [details] [diff] [review]: ----------------------------------------------------------------- Interesting. I was only checking `hdiutil attach -help`. There is this option not listed. But it is present via man across all OS X versions. So it should be good to get it added. The only problem I currently see is with bug 969334. It would make it harder to spot this problem when you open an OS X machine. But I think that shouldn't block us here from getting the patch landed.
Attachment #8518493 -
Flags: review?(hskupin) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5cfb8deed2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3f5cfb8deed2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•