Closed Bug 1095151 Opened 5 years ago Closed 5 years ago

[mozinstall] Don't show finder window when installing a dmg on mac

Categories

(Testing :: Mozbase, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

No description provided.
Attachment #8518493 - Flags: review?(hskupin)
OS: All → Mac OS X
Philipp, what is -nobrowse doing? I cannot find any reference for this option. Also please do a try run, so we can see it doesn't regress something. Thanks
Comment on attachment 8518493 [details] [diff] [review]
mozinstall-nobrowse.diff

Review of attachment 8518493 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting. I was only checking `hdiutil attach -help`. There is this option not listed. But it is present via man across all OS X versions. So it should be good to get it added.

The only problem I currently see is with bug 969334. It would make it harder to spot this problem when you open an OS X machine. But I think that shouldn't block us here from getting the patch landed.
Attachment #8518493 - Flags: review?(hskupin) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3f5cfb8deed2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.