1095187 - [SHB] TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Aus Lacroix [:aus]]

I've been seeing this intermittently fail about 1/3 of the time if not more. We should probably disable it or fix it soon.

Comment 1

[Aus Lacroix [:aus]]

Failures: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=94207c21018d

Comment 2

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-06T15:37:23
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=gaia-try&job_id=284597
repository: gaia-try
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-453
buildname: b2g_ubuntu64_vm gaia-try opt test gaia-js-integration-3
revision: 94207c21018d

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 3

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-06T19:56:42
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=gaia-try&job_id=284753
repository: gaia-try
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-452
buildname: b2g_ubuntu64_vm gaia-try opt test gaia-js-integration-3
revision: 94207c21018d

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 4

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-06T19:56:43
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=gaia-try&job_id=284751
repository: gaia-try
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-710
buildname: b2g_ubuntu64_vm gaia-try opt test gaia-js-integration-3
revision: 94207c21018d

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 5

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-06T19:56:43
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=gaia-try&job_id=284752
repository: gaia-try
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-639
buildname: b2g_ubuntu64_vm gaia-try opt test gaia-js-integration-3
revision: 94207c21018d

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

I think this might have been related to your PR? Have you seen this on master/b2g-inbound? Can we close?

Comment 7

[Aus Lacroix [:aus]]

Still intermittent on b2g-inbound.

Comment 8

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-07T17:19:51
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=b2g-inbound&job_id=799365
repository: b2g-inbound
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-002
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-js-integration-3
revision: d202d770bbc4

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 9

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-07T17:19:51
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=b2g-inbound&job_id=799179
repository: b2g-inbound
who: glacroix[at]mozilla[dot]com
machine: tst-linux64-spot-100
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-js-integration-3
revision: 19ff41e86cd0

TEST-UNEXPECTED-FAIL | null | Software Home Button - File Open Error Proper layout for file error dialog
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 10

[Kevin Grandon :kgrandon]

Looks like this was caused by bug 1077595. Normally this would call for a backout of the patch. That is a 2.0 blocker though, so perhaps we might consider disabling the test assuming we make it our top priority.

Comment 11

[Kevin Grandon :kgrandon]

Attachment: Screenshot at point of failure

Here is a screenshot at the point where the test fails. It looks like it opens the settings activity instead of opening the file directly now? Seems like it could be a real regression.

Comment 12

[Aus Lacroix [:aus]]

This is a hunch based on the screenshot but I think the issue is with the test. We bring up the file dialog when the download notification is pressed *and* the download has succeeded. If the download is not in a succeeded state we take the user to the Settings > Downloads activity.

It looks like the download will sometimes finish fast enough for the test to pass. Adding an onstatechange listener to the download and waiting for a "succeeded" state should work. Or we can wait for the download notification content to read the correct succeeded state copy before moving on.

Comment 13

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1095187_debug_download_intermittent_test to mozilla-b2g:master

Comment 14

[Kevin Grandon :kgrandon]

Thanks Aus - I'll take a look, and I'm trying the above patch with some additional logging/waiting. It also seems that this behavior was either broken prior to bug 1077595 landing, or that bug changed something? I will look into it this week.

Comment 16

[Aus Lacroix [:aus]]

That bug 1077595 added an extra layer of asynchronous callbacks. I wouldn't be surprised that this has changed the timing of how things occur just enough to cause these issues. I'll look at who wrote the test in the first place and try and fix it on my end today.

Comment 17

[Kevin Grandon :kgrandon]

Thanks Aus. I'm pretty sure this is from a test I wrote, which all it did was click on the notification :) There may be other ways of doing it. I'm currently testing out a fix in the attached pull request, but lots of infra issues today - which is why the trees are closed I guess. Maybe there's a better way of getting to the download, instead of clicking on the notification, it just seemed like the easiest method.

Comment 18

[Aus Lacroix [:aus]]

Gotcha. :) Not a bad way to get to it, I've re-triggered the a bunch of jobs (looks like you did too). We'll see how it goes. 

I've assigned this bug to myself for now, if it's still an issue by the end of the day I will ni? you. :)

Comment 19

[Aus Lacroix [:aus]]

Comment on attachment 8519602 [details] [review]
[PullReq] KevinGrandon:bug_1095187_debug_download_intermittent_test to mozilla-b2g:master

Kevin, that PR looks like it does indeed fix the issue with the test. Awesomesauce.

Comment 20

[Aus Lacroix [:aus]]

Re-assigning to :kgrandon since his PR fixes the issue.

Comment 21

[Kevin Grandon :kgrandon]

Thanks Aus, and sorry for the fragile test. Still waiting on a green run due to the infra issues. I'll restart this one a bunch just to be "double" sure, and we can land assuming it's good.

Comment 22

[Aus Lacroix [:aus]]

Yeah, in the previous try run, I triggered about 12 jobs and some failed, but with a Browser test (which is known, I believe). The test we care about passed for all runs. I'll wait for this latest one to wrap-up and if it looks good I will land on 2.2 and uplift along with bug 1077595 when it's approved.

Comment 23

[Aus Lacroix [:aus]]

Try run looks awesome!

Commit (master): https://github.com/mozilla-b2g/gaia/commit/c680e54411a729a2ed040432cec4247fa2a8b44d

Fixed!

(Will be uplifted to 2.1 but *NOT* 2.0 when bug 1077595 approvals are complete)

Comment 24

[Kevin Grandon :kgrandon]

Thanks for landing it Aus! I'll mark this as fixed for now, then we can uplift with a=testonly.

Comment 25

[Aus Lacroix [:aus]]

Commit (v2.1): https://github.com/mozilla-b2g/gaia/commit/ee1e5462fa4777eaa7950e0d75706be4383ec007

Fixed! a=test-only.