Closed Bug 1095231 Opened 5 years ago Closed 5 years ago

about:accounts?action=migrateToDevEdition fails if there is no default profile

Categories

(Firefox :: Sync, defect)

defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.2
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1079835 +++

See bug 1079835  comment 36 and 37 for more.  Issue is almost certainly that things go pear shaped when no profile is marked as the default.
Attachment #8518592 - Flags: review?(past)
It seems like may also have a problem when there is only one profile since the following code wasn't modified:
http://hg.mozilla.org/mozilla-central/diff/1416eeab79a2/toolkit/profile/nsToolkitProfileService.cpp#l1.113
Comment on attachment 8518592 [details] [diff] [review]
0001-Bug-XXXXXXX-have-migration-of-sync-credentials-do-th.patch

Review of attachment 8518592 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry about that! Indeed, a common case is a single profile not marked as default. For that case however, we can do even better: check if a single profile exists (named "default", or not named "dev-edition-default") and use profileService.selectedProfile to migrate from.

This would be the right fix in my view, so r=me with that. If you don't have time to do it, just shout and I'll provide the additional fix myself.
Attachment #8518592 - Flags: review?(past) → review+
After some discussion on IRC I realized that my selectedProfile suggestion above stems from an incorrect understanding of the original bug reporter's setup. The patch is fine as it is.
https://hg.mozilla.org/integration/fx-team/rev/d2feecbe066f
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Iteration: --- → 36.2
Points: --- → 2
Flags: qe-verify+
Flags: firefox-backlog+
(In reply to Matthew N. [:MattN] (focused on Loop) from comment #1)
> It seems like may also have a problem when there is only one profile since
> the following code wasn't modified:
> http://hg.mozilla.org/mozilla-central/diff/1416eeab79a2/toolkit/profile/
> nsToolkitProfileService.cpp#l1.113

The good news is that there is nothing to migrate from when only one profile exists :)
Also keep in mind that the migration path is only meant to be taken in Aurora (that's where the UI is present), which will mark the default (non-Aurora) profile as such.
It's too late for me to re-look at the patch etc, but are we confident that aurora being the first install on the machine, then followed by a non-aurora install because they loved it so much works as expected?
We do need to uplift your patch to aurora, if that's what you are asking. There is no migration to be done when only Aurora is installed, but we still shouldn't be failing.
https://hg.mozilla.org/mozilla-central/rev/d2feecbe066f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Attached patch Patch for gumSplinter Review
Here is a rebased patch for Gum.
QA Contact: camelia.badau
This bug was verified with Aurora 35 on gum build. It no longer requires verification.
Status: RESOLVED → VERIFIED
Flags: qe-verify+ → qe-verify-
You need to log in before you can comment on or make changes to this bug.