1095231 - about:accounts?action=migrateToDevEdition fails if there is no default profile

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-XXXXXXX-have-migration-of-sync-credentials-do-th.patch

+++ This bug was initially created as a clone of Bug #1079835 +++

See bug 1079835  comment 36 and 37 for more.  Issue is almost certainly that things go pear shaped when no profile is marked as the default.

Comment 1

[Matthew N. [:MattN]]

It seems like may also have a problem when there is only one profile since the following code wasn't modified:
http://hg.mozilla.org/mozilla-central/diff/1416eeab79a2/toolkit/profile/nsToolkitProfileService.cpp#l1.113

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8518592 [details] [diff] [review]
0001-Bug-XXXXXXX-have-migration-of-sync-credentials-do-th.patch

Review of attachment 8518592 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry about that! Indeed, a common case is a single profile not marked as default. For that case however, we can do even better: check if a single profile exists (named "default", or not named "dev-edition-default") and use profileService.selectedProfile to migrate from.

This would be the right fix in my view, so r=me with that. If you don't have time to do it, just shout and I'll provide the additional fix myself.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

After some discussion on IRC I realized that my selectedProfile suggestion above stems from an incorrect understanding of the original bug reporter's setup. The patch is fine as it is.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/d2feecbe066f

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Matthew N. [:MattN] (focused on Loop) from comment #1)
> It seems like may also have a problem when there is only one profile since
> the following code wasn't modified:
> http://hg.mozilla.org/mozilla-central/diff/1416eeab79a2/toolkit/profile/
> nsToolkitProfileService.cpp#l1.113

The good news is that there is nothing to migrate from when only one profile exists :)
Also keep in mind that the migration path is only meant to be taken in Aurora (that's where the UI is present), which will mark the default (non-Aurora) profile as such.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

It's too late for me to re-look at the patch etc, but are we confident that aurora being the first install on the machine, then followed by a non-aurora install because they loved it so much works as expected?

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

We do need to uplift your patch to aurora, if that's what you are asking. There is no migration to be done when only Aurora is installed, but we still shouldn't be failing.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2feecbe066f

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch for gum

Here is a rebased patch for Gum.

Comment 10

[Eddy Bruel [:ejpbruel]]

Landed this on gum:
https://hg.mozilla.org/projects/gum/rev/21d59fe5db66

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21d59fe5db66

Comment 12

[Camelia Badau [:cbadau], Desktop QA]

This bug was verified with Aurora 35 on gum build. It no longer requires verification.