1095260 - Tests that switch windows are racy with e10s turned on

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

After working around bug 1095236, tests that switch windows (at least test_import_script_reuse_window.py and test_window_switching.py) can deadlock. It looks like switchToWindow loading marionette-listener.js happens later with e10s turned on and the next command hangs as a result. Adding a delay for instance at http://hg.mozilla.org/mozilla-central/file/678dd5860cce/testing/marionette/client/marionette/tests/unit/test_import_script_reuse_window.py#l22 makes this test pass.

I guess we can wait for the script to finish loading before returning from switch_to_window or foist this responsibility on callers. David, do you have any advice on a way to proceed here?

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Waiting seems like the way here. Allowing the frame script's :register call to trigger sendOk instead of doing it in switchToFrame works fine, except for tests switching to a xul window, where loadFrameScript somehow doesn't get back to the parent. I guess I'll look into that next.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script

This is slightly gross, but with it the window switching tests (except for those asserting crazy things about being in the main process) all pass with e10s turned on. The issue with the test.xul window was that the ChromeMessageSender for this window didn't have any child message managers to broadcast to, so we never got the register call we expected. Explicitly checking for how many child message managers we have and waiting for them works ok locally.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3fe69fcfe238

Comment 3

[Chris Manchester (limited bugmail, email directly)]

This isn't really need info, I'll ask for review if try comes back ok.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script

This should do better.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=383a4e705350

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script

Less broken on b2g:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=83a3babdc597
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=19a4c0928270

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1095260/chmanchester

Comment 7

[Chris Manchester (limited bugmail, email directly)]

/r/371 - Bug 1095260 - Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script.

Pull down this commit:

hg pull review -r db59f11f4a4501892a958bc7b713ef12cac22555

Comment 8

[Chris Manchester (limited bugmail, email directly)]

/r/371 - Bug 1095260 - Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script.

Pull down this commit:

hg pull review -r db59f11f4a4501892a958bc7b713ef12cac22555

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Selection carets tests pass now when I run them locally. If we can agree not to block on bug 1095236 (using "dialog=1" appears incidental to those tests), then this bug is the last source of failures in the current set of marionette tests with e10s turned on.

Comment 10

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/369/#review399

looks good to me

Comment 11

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28ed24c69091

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28ed24c69091

Comment 14

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1095260 - Make the response from a switch_to_frame call correspond to the completion of loading the marionette listener script.