1095299 - Filepicker does not show directories if ui.allow_platform_file_picker is false

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Hartmut Figge]

With ui.allow_platform_file_picker set to false using File->Open in the browser on SM-Trunk opens the filepicker, but the field behind 'Look in' is empty and cannot be changed. Workaround: put the path before the filename. The error console shows

Error: ReferenceError: numFilters is not defined
Source File: chrome://global/content/filepicker.js Line: 82

Regression window is
Last good: 2014-11-04 16:15:00 PST
First bad: 2014-11-05 16:39:00 PST

Comment 1

[Mats Palmgren (inactive)]

Attachment: screenshot after clicking on the Home button

It's broken in Firefox too.  The dropdown list is empty and clicking
on the Home button (in the upper right) displays an error message.

Comment 2

[Mats Palmgren (inactive)]

Regression range FF mozilla-central:  2014-11-05-03-02-03  -- 2014-11-06-03-02-01
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=62990ec7ad78&tochange=2114ef80f6ae

Comment 3

[Mats Palmgren (inactive)]

Bisecting m-i gives this changeset that broke it:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a7f16c817b

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix

Comment 5

[Hartmut Figge]

(In reply to Mats Palmgren (:mats) from comment #4)
> Created attachment 8519492 [details] [diff] [review]
> fix

Works for my SM-Trunk Linux x86_64

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f642ef2068a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f642ef2068a