Closed
Bug 1095332
Opened 10 years ago
Closed 10 years ago
B2G RIL: fix false alarms "WARNING: 'jsapi.Init(mWindow)'..."
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: jessica, Assigned: jessica)
Details
Attachments
(1 file)
|
8.57 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
We have |if (!NS_WARN_IF(jsapi.Init(mWindow)))| in several places, which will print warnings that are false alarms in debug build.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8518709 [details] [diff] [review] patch. Edgar, may I have your review? Thanks.
Attachment #8518709 -
Flags: review?(echen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8518709 [details] [diff] [review] patch. Review of attachment 8518709 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch. ;)
Attachment #8518709 -
Flags: review?(echen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
try looks good! https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7b540a9d2754
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/208fe5cf00d6
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/208fe5cf00d6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•