1095345 - [Midori 2.0][3rd APK][Firefox Hello]It can't log in with phone number or Firefox Account.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Loop, defect, P2)

Description

[sync-1]

FFOS2.0 baseline BuildID: 20140916000205
 
 DEFECT DESCRIPTION:
 It can't log in with phone number or Firefox Account.
 
 REPRODUCING PROCEDURES:
 Pre:The phone number and Firefox Account has been verified
 1.Launch Firefox Hello;
 2.tap "Use phone number"->it stays in the "Authenticating" screen>KO1
 3.tap "Use Firefox Account"->Display "didn't work as expected"->KO2
 
 EXPECTED BEHAVIOUR:
 Can log in with phone number and Firefox Account.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 SWV2E6+ZZ01
 
 USER IMPACT:
 high
 
 REPRODUCING RATE:
 5/5
 For FT PR, Please list reference mobile's behavior:

Comment 1

[Lingling Zhao]

Dear Wesly，

Please notify developer about this issue, thanks.

Comment 2

[sync-1]

Attachment: Screenshot

Comment 3

[sync-1]

Attachment: LOG

Comment 4

[Beatriz Rodríguez [:brg]]

We sent some instructions last Friday through your Spanish team about how you should modify the build. Could you please confirm that this issue is fixed after those changes?

Comment 5

[Maria Angeles Oteo (:oteo)]

as Beatriz says in comment 4, according to the logs, it seems the build is not including the right information for 3rd party apps and that is causing Loop authentication to fail.

In the logcat you can see:

get assertion for app://loop.gaiamobile.org

which means that the authentication is not going to work as the origin should be app://loop.services.mozilla.com without using the right origin, assertions are not going to be valid

Comment 6

[Lingling Zhao]

Yes, it is ok now. 
Thanks all your support.

Comment 7

[Lingling Zhao]

(In reply to Lingling Zhao from comment #6)
> Yes, it is ok now. 
> Thanks all your support.

Sorry, It is not ok, because the origin is generated by build.

Comment 8

[Lingling Zhao]

(In reply to Maria Angeles Oteo (:oteo) from comment #5)
> as Beatriz says in comment 4, according to the logs, it seems the build is
> not including the right information for 3rd party apps and that is causing
> Loop authentication to fail.
> 
> In the logcat you can see:
> 
> get assertion for app://loop.gaiamobile.org
> 
> which means that the authentication is not going to work as the origin
> should be app://loop.services.mozilla.com without using the right origin,
> assertions are not going to be valid

Dear Maria，

The logcat you use to analyze the issue is the old one that the origin is app://loop.gaiamobile.org in that time. Then we update the preload-app-toolkit to download the app again, and in newly build, the origin is auto generated during build, but the issue still happens.

Please see the new attachment firefox-hello.txt. 
origin：app://{38044b5c-2bea-42b4-9242-6fd5ec76d57b}

Thanks.

Comment 9

[Lingling Zhao]

Attachment: firefox-hello.txt

Comment 10

[Daniel Coloma:dcoloma]

(In reply to Lingling Zhao from comment #8)
> (In reply to Maria Angeles Oteo (:oteo) from comment #5)
> > as Beatriz says in comment 4, according to the logs, it seems the build is
> > not including the right information for 3rd party apps and that is causing
> > Loop authentication to fail.
> > 
> > In the logcat you can see:
> > 
> > get assertion for app://loop.gaiamobile.org
> > 
> > which means that the authentication is not going to work as the origin
> > should be app://loop.services.mozilla.com without using the right origin,
> > assertions are not going to be valid
> 
> Dear Maria，
> 
> The logcat you use to analyze the issue is the old one that the origin is
> app://loop.gaiamobile.org in that time. Then we update the
> preload-app-toolkit to download the app again, and in newly build, the
> origin is auto generated during build, but the issue still happens.
> 
> Please see the new attachment firefox-hello.txt. 
> origin：app://{38044b5c-2bea-42b4-9242-6fd5ec76d57b}
> 
> Thanks.

The origin cannot be autogenerated, as the origin is linked to the server used for Authentication, that's why when you don't use the right origin (app://loop.services.mozilla.com) the authentication does not work. I.e. the only way to make it work is ensuring when you generate the build, the right origin (and not an autogenerated one) is used.

When we did some testings we used a script to create the app in a way that is moved to a specific folder (outoftree_apps) which apps are "imported" when generating the build (https://github.com/mozilla-b2g/gaia/blob/master/Makefile#L441). 

Let me know how else can we help

Comment 11

[Antonio Manuel Amaya Calvo (:amac)]

Ok, there seem to be some trickiness into getting the Gaia build system to generate the correct origin. A set of correct steps to do this is:

1. On the Gaia directory, execute:

cd outoftree_apps && mkdir loop && cd loop && cat << END_CAT > metadata.json
{
  "manifestURL": "https://marketplace.firefox.com/app/54b83aea-1208-4605-82eb-22819f39d81d/manifest.webapp",
  "installOrigin": "https://marketplace.firefox.com",
  "removable": true,
  "type": "privileged",
  "external": true
}
END_CAT

wget https://marketplace.firefox.com/app/54b83aea-1208-4605-82eb-22819f39d81d/manifest.webapp && mv manifest.webapp update.webapp

2. Copy the supplied zip with into the directory:

cp zip_with_hello_app.zip application.zip

It is *very* important to name the zip application.zip. Otherwise the build will be created incorrectly


The directory contents should be as shown below:

amac@peregrin:~/dev/gaiaClean/outoftree_apps/loop$ ls -al
total 5920
drwxrwxr-x 2 amac amac    4096 Nov 14 11:46 .
drwxrwxr-x 4 amac amac    4096 Nov 14 11:21 ..
-rw-rw-r-- 1 amac amac 6044614 Nov 10 14:00 application.zip
-rw-rw-r-- 1 amac amac     231 Nov 14 11:11 metadata.json
-rw-rw-r-- 1 amac amac     548 Nov 14 11:30 update.webapp

3. Now you can create the build as you usually do. You can check that the build is correctly creating by doing the following steps *after* the build is done. On the gaia directory, execute:

ls -l profile/webapps/loop.services.mozilla.com

The result should be something like:

total 5908
-rw-rw-r-- 1 amac amac 6044614 Nov 14 11:22 application.zip
-rw-rw-r-- 1 amac amac     548 Nov 14 11:22 update.webapp

Then you can execute:

diff profile/webapps/loop.services.mozilla.com/update.webapp outoftree_apps/loop/update.webapp 

The result should be empty (nothing should be written as both files should be identical).

Comment 12

[Lingling Zhao]

Dears，

Ａfter we changed the origin to app://loop.gaiamobile.org, the app can work. However as we are not fully familiar with this applciation we prefer more test and confirm..

Comment 13

[Daniel Coloma:dcoloma]

(In reply to Lingling Zhao from comment #12)
> Dears，
> 
> Ａfter we changed the origin to app://loop.gaiamobile.org, the app can work.
> However as we are not fully familiar with this applciation we prefer more
> test and confirm..

We performed some basic testing and the app worked as expected.

thanks!