1095391 - The uppercase key pop would show lowercase when it is disappearing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

STR
===
1. Launch the keyboard and keep it in uppercase mode.
2. Tap on a key, like 'I' to make key popup show.
3. Release the key and see the popup is fading out.
   => At the same time, you would see lowercase popup.

--
Should be a regression.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

This patch should be able to solve this regression.
However, I kind-of re-introduce the '{upperCase: true}' option back to the highlight() method, which I remember we removed before.

This is the best way I can think of, so set feedback? first to see if you agree this is a proper fix.
Thanks.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This would depends on the patch bug 1100777.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8525983 [details] [review]
Patch V1

Looks good, thank you. The only improvement I could ask for is to use css classes to toggle visibility, instead of set an inline style

https://github.com/RudyLu/gaia/commit/4f406f232d76c05a9961044ba0f3b9c13aaf8619#diff-dd9059d084d4eb39368074dbc7d87865R160

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8525983 [details] [review]
Patch V1

Patch updpated to address the review comments and add tests.
Also did some cleanup for the setUpperCase API of LayoutPageView.

Tim, please help review it.
Thanks.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8525983 [details] [review]
Patch V1

Please read Github comment. We should let the CSS do it's work if we could.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8525983 [details] [review]
Patch V1

Thanks for the advice, patch updated.
Could you please help review it again?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8525983 [details] [review]
Patch V1

Superb!

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

master,
https://github.com/mozilla-b2g/gaia/commit/fb700a6b518f68bdc4b619c5125f61aeb0b57b38

--
Thanks for the review!

Comment 9

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

lowercase letter is no longer appears when uppercase letter is entered

Device: Flame 2.2 Master (KK 319Mb Shallow Flash)
BuildID: 20141125040209
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

2.2+ all fixed regressions -- reset if disagree.