1095575 - DoesD3D11DeviceWork() should be overridable by force-enable prefs

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: forceenable

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=19196e12af53

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8519006 [details] [diff] [review]
forceenable

Review of attachment 8519006 [details] [diff] [review]:
-----------------------------------------------------------------

Get bas to review this.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53646a4233e0

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53646a4233e0

Comment 4

[André Ziegler]

can we get this fix in 34beta, too? I run a Intel/AMD laptop and HW acceleration is now disabled since 34b7 and the fonts look to ugly. I want to re- enable it.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8519006 [details] [diff] [review]
forceenable

Approval Request Comment
[Feature/regressing bug #]:1095575
[User impact if declined]: Users can't force HW acceleration
[Describe test coverage new/current, TBPL]: None
[Risks and why]: Pretty limited because it requires a pref change to enable

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8519006 [details] [diff] [review]
forceenable

We can definitely take it in Aurora, leaving the beta nom for Lawrence's final call given our proximity to final builds.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0268d5d01503

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8519006 [details] [diff] [review]
forceenable

This change reverts the behaviour of the pref, which Jeff tells me we inadvertently changed in 33. As the fix is simple and this provides an out for people impacted by unnecessary blocklisting, Beta+.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c77506b180c8

Comment 10

[André Ziegler]

thanks for adding it to 34beta. Can't wait for the next beta build to enable Direct2D again.