Closed Bug 1095575 Opened 9 years ago Closed 9 years ago

DoesD3D11DeviceWork() should be overridable by force-enable prefs

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file)

forceenable
1.03 KB, patch
bas.schouten
: review+
lsblakk
: approval-mozilla-aurora+
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Comment on attachment 8519006 [details] [diff] [review]
forceenable

Review of attachment 8519006 [details] [diff] [review]:
-----------------------------------------------------------------

Get bas to review this.
Attachment #8519006 - Flags: review?(jmuizelaar) → review?(bas)
Attachment #8519006 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/53646a4233e0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
can we get this fix in 34beta, too? I run a Intel/AMD laptop and HW acceleration is now disabled since 34b7 and the fonts look to ugly. I want to re- enable it.
Comment on attachment 8519006 [details] [diff] [review]
forceenable

Approval Request Comment
[Feature/regressing bug #]:1095575
[User impact if declined]: Users can't force HW acceleration
[Describe test coverage new/current, TBPL]: None
[Risks and why]: Pretty limited because it requires a pref change to enable
Attachment #8519006 - Flags: approval-mozilla-beta?
Attachment #8519006 - Flags: approval-mozilla-aurora?
Comment on attachment 8519006 [details] [diff] [review]
forceenable

We can definitely take it in Aurora, leaving the beta nom for Lawrence's final call given our proximity to final builds.
Attachment #8519006 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8519006 [details] [diff] [review]
forceenable

This change reverts the behaviour of the pref, which Jeff tells me we inadvertently changed in 33. As the fix is simple and this provides an out for people impacted by unnecessary blocklisting, Beta+.
Attachment #8519006 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
thanks for adding it to 34beta. Can't wait for the next beta build to enable Direct2D again.
You need to log in before you can comment on or make changes to this bug.