Closed
Bug 1095758
Opened 10 years ago
Closed 10 years ago
Fix use of uninitialized value $hostname in Mailer.pm
Categories
(Bugzilla :: Email Notifications, defect)
Bugzilla
Email Notifications
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: koosha.khajeh, Assigned: koosha.khajeh)
Details
Attachments
(1 file)
|
480 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Typically, urlbase is set on production servers but if you leave it blank, Bugzilla would still work and Apache would throw an error when Bugzilla tries to send emails:
process_bug.cgi: Use of uninitialized value $hostname in concatenation (.) or string at Bugzilla/Mailer.pm line 158.
Attachment #8519232 -
Flags: review?(dkl)
|
||
Comment 1•10 years ago
|
||
There are tons of warnings thrown when urlbase is not set, and index.cgi asks you to set urlbase if it's empty. I wouldn't care about this situation, really.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8519232 [details] [diff] [review]
patch
Review of attachment 8519232 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me. r=dkl
Attachment #8519232 -
Flags: review?(dkl) → review+
|
|
||
Updated•10 years ago
|
Flags: approval?
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
Target Milestone: Bugzilla 4.4 → Bugzilla 5.0
|
|
||
Comment 3•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
c0156f2..e4da3e9 master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
0b19b10..ff42357 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•