1095774 - [Text Selection] Choosing "select all" when only 1 word is displayed dismisses the keyboard but not the menu.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Seth Miko [:SMiko]]

Attachment: SelectAll.txt

Description: When using text selection on a single word in Messages, clicking on the select all icon deselects the word and dismisses the keyboard. The text selection menu remains displayed. 

Repro Steps:
1: Update a Flame to 20141107073659
2: Open Messages and type a single word into the body of the message.
3: Long tap on the word to invoke the text selection menu. 
4: Click on the "Select all" icon.

Actual: The text looses focus, the keyboard dismisses, and the text selection menu remains displayed. 

Expected: The text remains selected.

Device: Flame 2.2 (319mb/shallow flash)
BuildID: 20141107073659
Gaia: 779f05fead3d009f6e7fe713ad0fea16b6f2fb31
Gecko: b62ccf3228ba 
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Repro frequency: 5/5

See attached: logcat

Video clip: http://youtu.be/5OyAMdSCBLs

Comment 1

[Seth Miko [:SMiko]]

This issue does NOT repro on Flame 2.1 (319mb/shallow flash) as the text selection feature does not exist. 

Device: Flame 2.1
BuildID: 20141107001205
Gaia: 6295f6acfe91c6ae659712747dd2b9c8f51d0339
Gecko: 8c23b4f2ba29
Gonk: 
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
_________________________________________________________________________________________________________

This issue DOES repro on yesterday's Flame 2.2 (319mb/full flash)

Actual result: The text looses focus, the keyboard dismisses, and the text selection menu remains displayed.

Device: Flame 2.2 (319mb/full flash)
BuildID: 20141106040207
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: a074c0112919
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Julien Wajsberg [:julienw]]

Hey Gregor, this sounds like a copy/paste subsystem issue. Do you know which component this should moved to? Is it part of System FE?

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Hey Gregor, this sounds like a copy/paste subsystem issue. Do you know which
> component this should moved to? Is it part of System FE?

Forwarding to Tim

Comment 4

[Steve Chung [:steveck]]

Ni George and Morris for copy paste issue.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

I believe this bug has involve two works:
1. user has selected the leftest gesture bar, so it loses focus and close keyboard
   => gaia work, I should raise bubble's zindex higher than the bar.
2. when tapping on gesture bar, gaia should also receive selectionchange event to hidden the bubble.
   => I think Peter has a fix for it which will bind "blur" with selectionchange, and it can solve this problem. ni peter

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Comment 7

[howie [:howie]]

This is a 2.2 feature.

Comment 8

[Peter Chang[:pchang]]

(In reply to George Duan [:gduan] [:喬智] from comment #5)
> I believe this bug has involve two works:
> 1. user has selected the leftest gesture bar, so it loses focus and close
> keyboard
>    => gaia work, I should raise bubble's zindex higher than the bar.
> 2. when tapping on gesture bar, gaia should also receive selectionchange
> event to hidden the bubble.
>    => I think Peter has a fix for it which will bind "blur" with
> selectionchange, and it can solve this problem. ni peter

The blur issue will be fixed at bug 1090008 which will be landed soon.

Comment 9

[Julien Wajsberg [:julienw]]

George, assigning to you as I think it's a System bug and you have a patch for this. Please unassign and change component if it's wrong :)

Comment 10

[Kai-Chih Hu [:khu]]

(In reply to George Duan [:gduan] [:喬智] from comment #6)
> Created attachment 8521109 [details] [review]
> PR to master

Does it mean you are the best one to own it?

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8521109 [details] [review]
PR to master

Hi Alive,
could you review this patch?
I raise z-index of text-selection bubble higher than gesture bar and other system element.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8521109 [details] [review]
PR to master

You should test it in fullscreen, too.
#screen:-moz-full-screen-ancestor > [data-z-index-level="text-selection-dialog"] {
  z-index: 2147483647;
}

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/b1956029b0cba10ffe0faad80581de76220a962a

Comment 14

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2&3.0 by the STR in Comment 0.

Actual results: Tapping "Select all" icon when only 1 word is displayed will not dismiss the keyboard, and the background color of the word is highlighted with blue normally.

See attachment: verified_v2.2&3.0.3gp
Reproduce rate: 0/10


Device: Flame v2.2 build(Verified) 
Build ID               20150624162504
Gaia Revision          1f8981d7872e3c0053571c26fb3edaf401844d75
Gaia Date              2015-06-19 13:22:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2f8b845e5fa3
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150624.195750
Firmware Date          Wed Jun 24 19:58:02 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Verified)
Build ID               20150624080416
Gaia Revision          eb0d4aefa62b20420d6fa0642515a110daca5d97
Gaia Date              2015-06-24 01:48:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4cdc1a95a672
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150624.153831
Firmware Date          Wed Jun 24 15:38:44 EDT 2015
Bootloader             L1TC000118D0

-----------------------------------------------------------------------------------------
Note:
The text selection caret bubble is clipped by Keyboard in Message, please see Bug 1060199.

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2&3.0.3gp