Closed
Bug 1096155
Opened 10 years ago
Closed 10 years ago
nsTSubstring_CharT::Assign reports wrong OOM size
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: away, Assigned: away)
Details
Attachments
(1 file)
|
916 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Some callers pass -1 to nsTSubstring_CharT::Assign to mean that the length is unknown and should be computed. If that allocation fails, we pass the -1 through to NS_ABORT_OOM. It leads to nonsense 4GB OOM annotations such as bp-e7959473-ebea-4c7d-9167-f32e52141110.
Assignee: nobody → dmajor
Attachment #8519701 -
Flags: review?(nfroyd)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8519701 [details] [diff] [review] 1096155 Review of attachment 8519701 [details] [diff] [review]: ----------------------------------------------------------------- Whoops!
Attachment #8519701 -
Flags: review?(nfroyd) → review+
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1c2305de473
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•