1096245 - Character counter CSS needs tweaks on Windows

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: char-count-win.png

It looks like there's a gap between the counter and the edges of the textbox. The error border (the red border) also has a gap between it and the textbox edges on the left and right.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: char-count-err-win.png

Comment 2

[aleth [:aleth]]

Don't forget to check the popup bar that appears when replying to a tweet as well. Thanks!

Comment 3

[Patrick Cloke [:clokep]]

I'm going to take this to not forget about it. But someone can feel free to steal this if they'd like.

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Fix v1

Uploading images in a second.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Char counter with patch

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Char counter error with patch

Comment 7

[aleth [:aleth]]

Comment on attachment 8527176 [details] [diff] [review]
Fix v1

Review of attachment 8527176 [details] [diff] [review]:
-----------------------------------------------------------------

Does aero need any specific/separate changes?

::: im/themes/conversation.css
@@ +340,1 @@
>    -moz-appearance: none;

I think we now have moz-appearance: none on all OS, so it can be moved to the earlier .conv-textbox rule for all OS in this file, simplifying the ifdef.

@@ -427,5 @@
>  }
>  
>  .splitter-bottom {
>    background: #ddd; /* match URL popup bottom edge from tabbrowser-*.css */
> -%ifdef XP_MACOSX

Doesn't removing this make an unintended change for Linux?

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Fix v2

Comment 9

[Patrick Cloke [:clokep]]

Attachment: Char counter error with patch v2

Comment 10

[aleth [:aleth]]

Comment on attachment 8527184 [details] [diff] [review]
Fix v2

Review of attachment 8527184 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, thanks!

Looking at the screenshot, I suspect the splitter-bottom was higher on Windows to match the width of the splitter between the nicklist and the conversation? If you prefer to keep the splitter-bottom thicker, you could change its height only when the reply-to bar is shown (or simply not worry about that edge case). Go with what you think looks best for Windows.

Comment 11

[Patrick Cloke [:clokep]]

Landed it with the 1 px border. We need to tweak the Windows UI more, but I think this is an improvement.

https://hg.mozilla.org/comm-central/rev/18ae00dd170f