Closed Bug 1096326 Opened 10 years ago Closed 10 years ago

Lots of Loop test permafails when Gecko 35 merges to Beta

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
1

Tracking

(firefox35+ verified, firefox36 unaffected)

Status:
VERIFIED FIXED
Milestone:
mozilla35
Iteration:
36.3
Tracking Flags:
Tracking Status
firefox35 + verified
firefox36 --- unaffected
Blocking Flags:
backlog Fx35+

People

(Reporter: RyanVM, Assigned: mikedeboer)

References

Details

Attachments

(1 file)

Patch v1: rename loop.throttled pref to loop.throttled2 in places we missed
2.39 KB, patch
Unfocused
: review+
Details | Diff | Splinter Review
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0) > [Tracking Requested - why for this release]: Permafail across multiple test > suites when Gecko 35 merges to beta in a couple weeks. > > https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3033428&repo=try > https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3033431&repo=try > https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3033430&repo=try > https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3033429&repo=try > https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3033442&repo=try Hi Mike -- It looks like the tests are failing because they assume the Hello button is always there (even in the throttled state). I think Fx34 initially had similar failures. Do we need to make test changes to Fx35 (like we did for Fx34)?
Flags: needinfo?(mreavy) → needinfo?(mdeboer)
I expect we just need to update the tests prior to Fx35 going to Beta (to account for the throttling mechanism), but we need to resolve this within the next few days. So I'm setting the appropriate loop-blocking flags and priority.
backlog: --- → Fx35+
Priority: -- → P1
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Attachment #8522155 - Flags: review?(bmcbride)
Iteration: --- → 36.2
Points: --- → 1
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Added to IT 36.3
Iteration: 36.2 → 36.3
Flags: needinfo?(mmucci)
Comment on attachment 8522155 [details] [diff] [review] Patch v1: rename loop.throttled pref to loop.throttled2 in places we missed Review of attachment 8522155 [details] [diff] [review]: ----------------------------------------------------------------- Oops.
Attachment #8522155 - Flags: review?(bmcbride) → review+
Comment on attachment 8522155 [details] [diff] [review] Patch v1: rename loop.throttled pref to loop.throttled2 in places we missed Approval Request Comment [Feature/regressing bug #]: bug 1073215 [User impact if declined]: see comment 0 [Describe test coverage new/current, TBPL]: [Risks and why]: none, tests will keep running after uplift to beta. [String/UUID change made/needed]: n/a.
Attachment #8522155 - Flags: approval-mozilla-aurora?
Comment on attachment 8522155 [details] [diff] [review] Patch v1: rename loop.throttled pref to loop.throttled2 in places we missed I vote we call this a=test-only :)
Attachment #8522155 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/d16a5e2d6dd0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox35: affected → fixed
status-firefox36: --- → unaffected
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7) > I vote we call this a=test-only :) Hum, yeah, let's :) Thanks Ryan!
Confirmed that we're good :)
Status: RESOLVED → VERIFIED
status-firefox35: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: