Closed Bug 1096371 Opened 5 years ago Closed 5 years ago

DevTools Themes: Tabs with notifications too dark on Dev Edition Light theme

Categories

(Firefox :: Theme, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: jsantell, Assigned: bgrins)

References

Details

(Whiteboard: [devedition-polish])

Attachments

(3 files, 1 obsolete file)

Attached image notification screenshot
The black/dark glow looks really strange coming from a light blue light.
Blocks: 1093870
Whiteboard: [devedition-polish]
Assignee: nobody → bgrinstead
Attached patch pinned-glow-light.patch (obsolete) — Splinter Review
This looks better (screenshot incoming)
Attachment #8519999 - Flags: review?(dao)
Attached image with-patch.png
Screenshot with patch applied
Comment on attachment 8519999 [details] [diff] [review]
pinned-glow-light.patch

Why are you using rgba(29,79,115,0) rather than 'transparent'?
(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8519999 [details] [diff] [review]
> pinned-glow-light.patch
> 
> Why are you using rgba(29,79,115,0) rather than 'transparent'?

Not sure - Victor?
Flags: needinfo?(vporof)
Regardless, it shouldn't hurt to switch this to 'transparent'
Attachment #8519999 - Attachment is obsolete: true
Attachment #8519999 - Flags: review?(dao)
Flags: needinfo?(vporof)
Attachment #8520048 - Flags: review?(dao)
Attachment #8520048 - Flags: review?(dao) → review+
Keywords: checkin-needed
(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8519999 [details] [diff] [review]
> pinned-glow-light.patch
> 
> Why are you using rgba(29,79,115,0) rather than 'transparent'?

The fade-out is not the same when using 'transparent'. The colors blended differently before, but that said, I'm not against this change.
(In reply to Victor Porof [:vporof][:vp] from comment #6)
> (In reply to Dão Gottwald [:dao] from comment #3)
> > Comment on attachment 8519999 [details] [diff] [review]
> > pinned-glow-light.patch
> > 
> > Why are you using rgba(29,79,115,0) rather than 'transparent'?
> 
> The fade-out is not the same when using 'transparent'. The colors blended
> differently before, but that said, I'm not against this change.

Good point, I didn't think about that.

Pushed to fx-team:  https://hg.mozilla.org/integration/fx-team/rev/ab702308b93a
Keywords: checkin-needed
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
Status: NEW → ASSIGNED
(In reply to Victor Porof [:vporof][:vp] from comment #6)
> (In reply to Dão Gottwald [:dao] from comment #3)
> > Comment on attachment 8519999 [details] [diff] [review]
> > pinned-glow-light.patch
> > 
> > Why are you using rgba(29,79,115,0) rather than 'transparent'?
> 
> The fade-out is not the same when using 'transparent'. The colors blended
> differently before,

That was a style system bug that has since been fixed.
https://hg.mozilla.org/mozilla-central/rev/ab702308b93a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 36
Comment on attachment 8520048 [details] [diff] [review]
pinned-glow-light.patch

Approval Request Comment
[Feature/regressing bug #]: 1093870
[User impact if declined]: The notification on a pinned tab will look like this: https://bugzilla.mozilla.org/attachment.cgi?id=8519974 instead of this: https://bugzilla.mozilla.org/attachment.cgi?id=8520000
[Describe test coverage new/current, TBPL]: None, CSS change
[Risks and why]: Low risk, it's a style change to the Developer Edition theme
[String/UUID change made/needed]:
Attachment #8520048 - Flags: approval-mozilla-aurora?
Attachment #8520048 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.