1096371 - DevTools Themes: Tabs with notifications too dark on Dev Edition Light theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: notification screenshot

The black/dark glow looks really strange coming from a light blue light.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: pinned-glow-light.patch

This looks better (screenshot incoming)

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: with-patch.png

Screenshot with patch applied

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8519999 [details] [diff] [review]
pinned-glow-light.patch

Why are you using rgba(29,79,115,0) rather than 'transparent'?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8519999 [details] [diff] [review]
> pinned-glow-light.patch
> 
> Why are you using rgba(29,79,115,0) rather than 'transparent'?

Not sure - Victor?

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: pinned-glow-light.patch

Regardless, it shouldn't hurt to switch this to 'transparent'

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8519999 [details] [diff] [review]
> pinned-glow-light.patch
> 
> Why are you using rgba(29,79,115,0) rather than 'transparent'?

The fade-out is not the same when using 'transparent'. The colors blended differently before, but that said, I'm not against this change.

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Victor Porof [:vporof][:vp] from comment #6)
> (In reply to Dão Gottwald [:dao] from comment #3)
> > Comment on attachment 8519999 [details] [diff] [review]
> > pinned-glow-light.patch
> > 
> > Why are you using rgba(29,79,115,0) rather than 'transparent'?
> 
> The fade-out is not the same when using 'transparent'. The colors blended
> differently before, but that said, I'm not against this change.

Good point, I didn't think about that.

Pushed to fx-team:  https://hg.mozilla.org/integration/fx-team/rev/ab702308b93a

Comment 8

[Dão Gottwald [:dao]]

(In reply to Victor Porof [:vporof][:vp] from comment #6)
> (In reply to Dão Gottwald [:dao] from comment #3)
> > Comment on attachment 8519999 [details] [diff] [review]
> > pinned-glow-light.patch
> > 
> > Why are you using rgba(29,79,115,0) rather than 'transparent'?
> 
> The fade-out is not the same when using 'transparent'. The colors blended
> differently before,

That was a style system bug that has since been fixed.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab702308b93a

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8520048 [details] [diff] [review]
pinned-glow-light.patch

Approval Request Comment
[Feature/regressing bug #]: 1093870
[User impact if declined]: The notification on a pinned tab will look like this: https://bugzilla.mozilla.org/attachment.cgi?id=8519974 instead of this: https://bugzilla.mozilla.org/attachment.cgi?id=8520000
[Describe test coverage new/current, TBPL]: None, CSS change
[Risks and why]: Low risk, it's a style change to the Developer Edition theme
[String/UUID change made/needed]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/838f62a0fd9d