Closed
Bug 1096377
Opened 11 years ago
Closed 11 years ago
Don't allow duplicate parameter names in arrow functions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: anba, Assigned: arai)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
|
1.56 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Test case:
---
(a, ...a) => {}
---
Expected: SyntaxError is thrown
Actual: No SyntaxError
Arrow function parameters use the 'StrictFormalParameters' grammar production [1] which disallows duplicate parameter names [2].
[1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions
[2] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function-definitions-static-semantics-early-errors
|
||
Comment 1•11 years ago
|
||
I don't think a bug for each of these is helpful.
|
Assignee | |
Comment 2•11 years ago
|
||
applied after the patch in bug 1096376.
Already passed the try (same as bug 1096376):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91855352a697
Attachment #8553308 -
Flags: review?(jorendorff)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8553308 [details] [diff] [review]
Disallow duplicated parameter in arrow functions.
Review of attachment 8553308 [details] [diff] [review]:
-----------------------------------------------------------------
Yes please.
Attachment #8553308 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
||
Comment 5•11 years ago
|
||
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
||
Comment 6•11 years ago
|
||
Keywords: dev-doc-complete,
site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•