1096430 - Panel UI separator icon is wrong for Australis in dev edition 35

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Johan C]

Attachment: Buggy toolbar separator

STR: disable the Developer Edition theme

Actual result: separator looks buggy (see screenshot).

Comment 1

[Johan C]

Since posting this I've noticed that the menu icon looks scaled down. You can see this clearly in the screenshot posted above.

Comment 2

[Brian Grinstead [:bgrins]]

I think this is the same thing Tim was seeing.  I'll look into it.

Comment 3

[Brian Grinstead [:bgrins]]

I don't see this on m-c with a tip of 0c66a9fd9085 (https://hg.mozilla.org/mozilla-central/rev/0c66a9fd9085) so it must have landed after that.  A likely candidate is Bug 1094509

Comment 4

[Brian Grinstead [:bgrins]]

Weird thing is that I don't see this locally on a build, but I do in the devedition release.  Makes me thing something didn't get uplifted to aurora.

Comment 6

[Johan C]

Please take comment #1 into account as well

Comment 7

[Brian Grinstead [:bgrins]]

Copying over panelUIOverlay.inc.css from fx-team to aurora doesn't fix it.  Still trying to track it down

Comment 8

[Brian Grinstead [:bgrins]]

I'm not sure why, but switching 'transparent' to 'rgba(255, 255, 255, 0)' in this gradient fixes it:

http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#24-26

Comment 9

[Brian Grinstead [:bgrins]]

I wonder if it's somehow interacting with not having this changeset on aurora: https://hg.mozilla.org/mozilla-central/rev/3adeab7e472d.

Comment 10

[Brian Grinstead [:bgrins]]

Attachment: aurora-panel-separator-fix.patch

So, starting/ending at 'transparent' instead of 'hsla(0,0%,100%,0)' in the gradients for the panel ui button is causing issues on aurora.  I'm guessing that if we uplifted all of https://hg.mozilla.org/mozilla-central/raw-rev/3adeab7e472d it would solve this problem also, but this is a much simpler fix.

Comment 11

[Brian Grinstead [:bgrins]]

(In reply to Johan C from comment #6)
> Please take comment #1 into account as well

I'm also seeing a smaller panel button in osx/windows 7 (but not on nightly).  Maybe an icon change that wasn't uplifted?  I'll see if I can track that down.

Comment 12

[Johan C]

(In reply to Brian Grinstead [:bgrins] from comment #11)
> (In reply to Johan C from comment #6)
> > Please take comment #1 into account as well
> 
> I'm also seeing a smaller panel button in osx/windows 7 (but not on
> nightly).  Maybe an icon change that wasn't uplifted?  I'll see if I can
> track that down.

It looks squashed, if you compare the icons in the screenshot you can see that the icon is wider on the beta channel.

Comment 13

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #11)
> (In reply to Johan C from comment #6)
> > Please take comment #1 into account as well
> 
> I'm also seeing a smaller panel button in osx/windows 7 (but not on
> nightly).  Maybe an icon change that wasn't uplifted?  I'll see if I can
> track that down.

This appears to be a regression from 1080406, where there is a call to PanelUI.menuButton.classList.add("badged-button").  It's not clear to me why this is a problem only on DevEdition.  Matteo, any ideas why the panel ui button is smaller in the DevEdition release?

Comment 14

[Brian Grinstead [:bgrins]]

ni? for comment 13

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 8520179 [details] [diff] [review]
aurora-panel-separator-fix.patch

Just to be clear, this patch shouldn't land on mozilla-central.

Comment 16

[Brian Grinstead [:bgrins]]

Comment on attachment 8520179 [details] [diff] [review]
aurora-panel-separator-fix.patch

Approval Request Comment
[Feature/regressing bug #]: 1053434
[User impact if declined]: The separator for the panel button in australis is wrong
[Describe test coverage new/current, TBPL]: style change
[Risks and why]: Just changing 'transparent' to 'hsla(0,0%,100%,0)' in a css property
[String/UUID change made/needed]:

Comment 17

[Brian Grinstead [:bgrins]]

Moved needinfo to 1097062, since it is a different problem

Comment 18

[Brian Grinstead [:bgrins]]

Note: attachment 8520179 [details] [diff] [review] is meant only for aurora uplift, not for landing on m-c

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e35ec2feadde