Closed
Bug 1096517
Opened 10 years ago
Closed 10 years ago
Disable stumbler robocop test on 2.3
Categories
(Android Background Services Graveyard :: Geolocation, defect)
Tracking
(firefox35 fixed, firefox36 fixed, fennec-)
RESOLVED
FIXED
Firefox 36
People
(Reporter: garvan, Assigned: garvan)
Details
Attachments
(1 file)
652 bytes,
patch
|
gbrown
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug #1060705 is the stumbler robocop landing. Bug #986738 is where 2.3 tests were reported failing due to this. Disabling the test, then investigating.
Just added a line to disable on API level 10. I'll investigate this today as to _why_ this is happening.
Attachment #8520116 -
Flags: review?(gbrown)
Comment 2•10 years ago
|
||
Comment on attachment 8520116 [details] [diff] [review] bug1096517_disable_robocop_on_2.3.diff Review of attachment 8520116 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. It may be difficult to identify a cause. We have had to disable some other robocop tests on 2.3 for unexplained shutdown crashes.
Attachment #8520116 -
Flags: review?(gbrown) → review+
Thanks for the r+ Geoff, I am going to try and repro this locally and see if I can figure it out.
Keywords: checkin-needed
Pushed to try a few hours ago: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ae80a83c004e Waiting for result...
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c371b8e04118
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Comment on attachment 8520116 [details] [diff] [review] bug1096517_disable_robocop_on_2.3.diff Approval Request Comment [Feature/regressing bug #]: Stumbler for Fennec [User impact if declined]: None [Describe test coverage new/current, TBPL]: Bug 1060705 adds a new robocop test, this bug is disabling the failing test on Android 2.3 [Risks and why]: TBPL Android 2.3 robocop test will fail if Bug 1060705 lands without this. [String/UUID change made/needed]: None.
Attachment #8520116 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8520116 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2fb99d8c833
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Updated•10 years ago
|
tracking-fennec: ? → ---
Updated•10 years ago
|
tracking-fennec: --- → -
You need to log in
before you can comment on or make changes to this bug.
Description
•