Closed Bug 1096564 Opened 10 years ago Closed 6 years ago

Failure to update Tarako Marketplace

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: clouserw, Unassigned)

References

Details

In v1.3T the Marketplace's metadata.json has an origin of app://marketplace.firefox.com.[1]  The accompanying application.zip includes a manifest.webapp which has an origin of app://packaged.marketplace.firefox.com.

When a user tries to get a new version of the Marketplace the OS stops the upgrade claiming an origin mismatch.  This came up before in bug 962524 and it was determined that nothing could be done.  The practice of defining the origin in the metadata.json was dropped in 1.4 so this is no longer an issue with current builds.

Assuming bug 962524 is correct, we are unable to upgrade Tarako Marketplaces without taking a more extreme action (like pushing a gaia update to all phones - and even that will have questionable uptake).

However, we may be in a position to push a newer package to the Tarako branch before it's picked up by the next partner.  The primary question at this point is:

> Do we have the opportunity to land a new Marketplace package on the 1.3T branch before
> the next partner starts flashing phones?

If no, we lose out on all analytics but the rest of the Marketplace will function as expected.

If yes, I need to talk to someone on the platform team about the best way to avoid bad updates with the existing phones vs the new shipping phones.

[1] https://github.com/mozilla-b2g/gaia/blob/v1.3t/external-apps/marketplace.firefox.com/metadata.json#L5
See Also: → 1096555
Current status: Faramarz is investigating whether we have the opportunity to push a new package to the devices before they are flashed and shipped to our new region.
I don't think we're able to update the image for the next Tarako market (Philippines). However, I'd still like to see this progress, as there could be more new markets later this year for Tarako. Also, we can have the patch available for download/update, for Tarako devices already shipped. Thanks.
Wil,

Can you push the updated MP packet to 1.3T? As soon as this happens I'll notify our partner to take this so it gets applied to new markets/shipments.

Please ni me and Vance when it's ready.
Flags: needinfo?(clouserw)
Yes.  I have the patch ready but I'd like to confirm what will happen to end users.  Fabrice - maybe you know or could point us to someone who would?

The scenario:

Package A is on all shipping Tarako devices today and is on the Marketplace.  I uploaded Package B to the Marketplace.  All shipping Tarako devices are seeing prompts to upgrade to Package B and failing currently.  I'm planning on removing Package B from the Marketplace to prevent users from seeing the upgrade prompts.

If I remove Package B from the Marketplace but put it in Gaia will FirefoxOS attempt to upgrade those users to Package A (since that is the latest package in the Marketplace)?  If so, is there a way to avoid that?  Thanks.
Flags: needinfo?(fabrice)
(In reply to Wil Clouser [:clouserw] from comment #4)
> Yes.  I have the patch ready but I'd like to confirm what will happen to end
> users.  Fabrice - maybe you know or could point us to someone who would?
> 
> The scenario:
> 
> Package A is on all shipping Tarako devices today and is on the Marketplace.
> I uploaded Package B to the Marketplace.  All shipping Tarako devices are
> seeing prompts to upgrade to Package B and failing currently.  I'm planning
> on removing Package B from the Marketplace to prevent users from seeing the
> upgrade prompts.
> 
> If I remove Package B from the Marketplace but put it in Gaia will FirefoxOS
> attempt to upgrade those users to Package A (since that is the latest
> package in the Marketplace)?  If so, is there a way to avoid that?  Thanks.

If package A and package B have the same manifest URL, yes we will try to update, and we have no way to prevent that from happening right now.
Flags: needinfo?(fabrice)
Ok, thanks.  I'm going to suggest in the short term we:

1) Disable the Tarako App in the Marketplace.  This will return 404s for update checks and prevent our existing users from being prompted about updates they can't install.

2) Land the newest Tarako App in Gaia as requested in comment 3

Disabling the Tarako App in the Marketplace means no one will get updates.  If at some point in the future we need to update the new Tarako app again we can re-enable it and suffer through the failures to update on old devices, or attempt to do some hard-coded checking in the update script.  We can cross that bridge when we get there though.
Flags: needinfo?(clouserw)
Mathieu on the Marketplace team suggested that since we were pushing a new package to Gaia we could push one with an entirely new origin.  Then we could still do #1 above, but have the ability to push updates to the new Tarako phones in the future.  We're evaluating how much work that would be now.  Either way, when we get something for gaia it will be in bug 1092424 so look there if you want to stay up to date.  Thanks.
The original Tarako package has been delisted[1].  End users will no longer be prompted for updates they can't install.

There is a new Tarako package[2] (it's a hidden app on the Marketplace).

There is a pull request for Gaia[3] with the new package in it waiting for review.  Once it lands I think this bug will be closable.


[1] https://marketplace.firefox.com/app/marketplace-package/
[2] https://marketplace.firefox.com/app/marketplace-tarako/
[3] https://github.com/mozilla-b2g/gaia/pull/26157
The updated marketplace has landed on the 1.3T branch in gaia:

https://github.com/mozilla-b2g/gaia/tree/v1.3t/external-apps/marketplace.firefox.com

If you can take the new package make sure to take the new application.zip *and* the metadata.json.  Thanks.
Flags: needinfo?(wchang)
Flags: needinfo?(vchen)
Thanks Wil.

Vance, please inform partner to ensure the updated version MP is included on new releases from them going forward.
Flags: needinfo?(wchang)
Already inform partner about this change. Moving forward any 1.3T release from partner will include this updated marketplace

Thanks

Vance
Flags: needinfo?(vchen)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.