Don't call into Webdriver's isShown() method when attempting to manipulate content xul elements

RESOLVED FIXED in mozilla36

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
This is basically a work around for bug 1094246. The proper solution likely involves writing our own isShown method specifically for XUL elements. That is hard to do, so in the meantime, this will get us unblocked with regards to m21s.
(Assignee)

Updated

3 years ago
Blocks: 1096488
(Assignee)

Comment 1

3 years ago
Created attachment 8520206 [details]
MozReview Request: bz://1096571/ahal
Attachment #8520206 - Flags: review?(dburns)
(Assignee)

Comment 2

3 years ago
/r/379 - Bug 1096571 - Don't call into webdriver's isShown() method when manipulating content XUL in marionette, r=AutomatedTester

Pull down this commit:

hg pull review -r 4cae35e11ec6668a2c9402fc3b44f08ff1242243
https://reviewboard.mozilla.org/r/379/#review197

::: testing/marionette/client/marionette/tests/unit/test_click.py
(Diff revision 1)
> -    def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(self):
> +    def test_clicking_a_link_made_up_of_numbers_is_handled_correctly(self):

thank you :)
https://reviewboard.mozilla.org/r/379/#review199

Ship It!
Attachment #8520206 - Flags: review?(dburns) → review+
(Assignee)

Comment 5

3 years ago
Try runs look good:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d045cd9737c9&searchQuery=integration
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9926cff509a2

Will push when inbound is open again.
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fce3bbf560ca
https://hg.mozilla.org/mozilla-central/rev/fce3bbf560ca
Assignee: nobody → ahalberstadt
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
No longer blocks: 1096488
(Assignee)

Comment 8

2 years ago
Comment on attachment 8520206 [details]
MozReview Request: bz://1096571/ahal
Attachment #8520206 - Attachment is obsolete: true
Attachment #8618588 - Flags: review+
(Assignee)

Comment 9

2 years ago
Created attachment 8618588 [details]
MozReview Request: Bug 1096571 - Don't call into webdriver's isShown() method when manipulating content XUL in marionette, r=AutomatedTester
You need to log in before you can comment on or make changes to this bug.