1096571 - Don't call into Webdriver's isShown() method when attempting to manipulate content xul elements

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andrew Halberstadt [:ahal]]

This is basically a work around for bug 1094246. The proper solution likely involves writing our own isShown method specifically for XUL elements. That is hard to do, so in the meantime, this will get us unblocked with regards to m21s.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: bz://1096571/ahal

Comment 2

[Andrew Halberstadt [:ahal]]

/r/379 - Bug 1096571 - Don't call into webdriver's isShown() method when manipulating content XUL in marionette, r=AutomatedTester

Pull down this commit:

hg pull review -r 4cae35e11ec6668a2c9402fc3b44f08ff1242243

Comment 3

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/379/#review197

::: testing/marionette/client/marionette/tests/unit/test_click.py
(Diff revision 1)
> -    def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(self):
> +    def test_clicking_a_link_made_up_of_numbers_is_handled_correctly(self):

thank you :)

Comment 4

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/379/#review199

Ship It!

Comment 5

[Andrew Halberstadt [:ahal]]

Try runs look good:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d045cd9737c9&searchQuery=integration
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9926cff509a2

Will push when inbound is open again.

Comment 6

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fce3bbf560ca

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fce3bbf560ca

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1096571 - Don't call into webdriver's isShown() method when manipulating content XUL in marionette, r=AutomatedTester