1096682 - Stub out the favicon service

Status: RESOLVED FIXED

(Firefox for iOS :: Favicons, defect)

Description

[Wesley Johnston (:wesj)]

Splitting up bug 1094940 into some micro bugs. This will handle just creating a stub service and using it everywhere. This can just hardcode a single icon for now. I just want to make sure all callers travel through this API.

Note: Even though this is a single local icon, we want this API to support asynchronously loading an image into a view (that may be recycled).

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull Request

This is a basic stubbed out version of this Adds a Favicons Protocol with a BasicFavicons implementation. Cursor protocol. ArrayCursor<T> implementation. And uses both on the tabs we have.

I'm still not sure how to pass something like a Cursor<T>. I have a feeling it can't be done....

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8520457 [details] [review]
Pull Request

Looks fine for now -- we can tweak stuff as we move along.

(In reply to Wesley Johnston (:wesj) from comment #1)
> I'm still not sure how to pass something like a Cursor<T>. I have a feeling
> it can't be done....

So that's why getForUrls() uses ArrayCursor in the API rather than just Cursor? I agree that's something we should try to figure out, sooner than later, since it kind of kills the abstraction. Can you file a follow-up for this?

Comment 3

[Wesley Johnston (:wesj)]

Merged.