Closed Bug 1096748 Opened 10 years ago Closed 9 years ago

web-platform test audio_has_no_subtitles.html times out

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

webvtt/rendering/cues-with-video/processing-model/audio_has_no_subtitles.html uses a video-only WebM (and/or MP4, via <source>) test file.  This used to pass because we'd select the WebM version and the software decoder would happily decode and discard the video track.

Decoders based on the new MediaDataDecoder infrastructure do not enable video track decoding unless there's an appropriate ImageContainer available.  This includes MP4 and will include WebM when bug 922314 lands.  This causes the test to timeout, because there is no audio track and the video track is disabled, resulting in the decoder firing a decode error (due to there being no valid tracks).  The test doesn't catch or handle the decode error, and times out waiting for the media to load/play.

I'll file a bug against web-platform upstream to deal with the test, but in the mean time, here's a patch to mark the test as expected to time out.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #8520355 - Flags: review?(cpearce)
Comment on attachment 8520355 [details] [diff] [review]
bug1096748_v0.patch

Review of attachment 8520355 [details] [diff] [review]:
-----------------------------------------------------------------

Are we better to disable the test, to save wasting time waiting for a timeout that we expect to happen?
Attachment #8520355 - Flags: review?(cpearce) → review+
The w-p-t reftest timeout is quite short, ~15 seconds, and it looks like we have masses of w-p-t tests marked as TIMEOUT.  Very few (~8) are disabled (and none of the disabled are reftests; they're all testharness).  So I'll leave it enabled for now, "when in Rome...".
Silly me, I can't land this until bug 922314 lands, otherwise it passes for WebM and times out for MP4.

https://hg.mozilla.org/integration/mozilla-inbound/rev/98af9b39435d
Keywords: leave-open
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/ccaa14dc6d79
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.