1096750 - Expect error event in test_video_in_audio_element if used with video-only media

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

The changes in bug 922314 include a fix for bug 1060896 in the restructed WebM decoder.  test_video_in_audio_element will time out because the WebM used is video-only (it has no audio track), so loading it in an <audio> element results in no valid tracks being configured and a decode error event being raised.  Modify the test to expect an error in this situation rather than timing out.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug1096750_v0.patch

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8520354 [details] [diff] [review]
bug1096750_v0.patch

Review of attachment 8520354 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/test_video_in_audio_element.html
@@ +45,5 @@
>  
>      a.src = test.name;
>    }
>  
>    var videos = gSmallTests.filter(function(x){return /^video/.test(x.type);});

We now have getPlayableVideos() in manifest.js.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8520354 [details] [diff] [review]
bug1096750_v0.patch

Review of attachment 8520354 [details] [diff] [review]:
-----------------------------------------------------------------

Using getPlayableVideos() seems like a good idea.

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/234c07eb3438
https://hg.mozilla.org/integration/mozilla-inbound/rev/f92fbac59bcf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/234c07eb3438
https://hg.mozilla.org/mozilla-central/rev/f92fbac59bcf