If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Expect error event in test_video_in_audio_element if used with video-only media

RESOLVED FIXED in mozilla36

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The changes in bug 922314 include a fix for bug 1060896 in the restructed WebM decoder.  test_video_in_audio_element will time out because the WebM used is video-only (it has no audio track), so loading it in an <audio> element results in no valid tracks being configured and a decode error event being raised.  Modify the test to expect an error in this situation rather than timing out.
(Assignee)

Updated

3 years ago
Blocks: 1060896, 922314
(Assignee)

Comment 1

3 years ago
Created attachment 8520354 [details] [diff] [review]
bug1096750_v0.patch
Attachment #8520354 - Flags: review?(cpearce)
Comment on attachment 8520354 [details] [diff] [review]
bug1096750_v0.patch

Review of attachment 8520354 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/test_video_in_audio_element.html
@@ +45,5 @@
>  
>      a.src = test.name;
>    }
>  
>    var videos = gSmallTests.filter(function(x){return /^video/.test(x.type);});

We now have getPlayableVideos() in manifest.js.
Comment on attachment 8520354 [details] [diff] [review]
bug1096750_v0.patch

Review of attachment 8520354 [details] [diff] [review]:
-----------------------------------------------------------------

Using getPlayableVideos() seems like a good idea.
Attachment #8520354 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/234c07eb3438
https://hg.mozilla.org/integration/mozilla-inbound/rev/f92fbac59bcf
https://hg.mozilla.org/mozilla-central/rev/234c07eb3438
https://hg.mozilla.org/mozilla-central/rev/f92fbac59bcf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.