1096778 - Include browser-element.xpt that defines the nsIBrowserElementAPI interface

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1044736#c42

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1096778_browser-element.xpt.patch

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8522465 [details] [diff] [review]
bug1096778_browser-element.xpt.patch

Review of attachment 8522465 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for including im/ in this!

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8522465 [details] [diff] [review]
bug1096778_browser-element.xpt.patch

also a+ for seamonkey's closed tree

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/5c7a3bfe09cc -> FIXED

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/comm-central/rev/3071390b0e4d because the mozilla-central patches were backed out, so this would break things.

I'm unsure exactly what the protocol is for these things. Do I reopen this bug or leave it closed?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

IRC Callek said to reopen.

Comment 7

[Magnus Melin [:mkmelin]]

Relanded as https://hg.mozilla.org/comm-central/rev/8a5a260c145d as bug 1044736 relanded.

Comment 8

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-22T16:04:35
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=3871
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-lion-r5-075
buildname: TB OS X 10.7 comm-central build
revision: 4dccd9337159

make[3]: *** [stage-package] Error 1
make[2]: *** [postflight_all] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-22T16:04:35
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=3868
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-lion-r5-062
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 4dccd9337159

make[3]: *** [stage-package] Error 1
make[2]: *** [make-package] Error 2
make[1]: *** [default] Error 2
make: *** [package] Error 2

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Attachment: follow_up_fix_for_bug1096778.patch

Use @RESPATH instead of @BINPATH.
The path name has been changed since bug 1096494.

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 8527248 [details] [diff] [review]
follow_up_fix_for_bug1096778.patch

Review of attachment 8527248 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! unbitrot fail on my end

Comment 12

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/f395004bbc3f -> FIXED