1096824 - [Loop] Sign up requests might be unauthorized due to assertion certificate expired

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

We are seeing 'WWW-Authenticate BrowserID error="expired"' server responses on sign up requests. Need to handle better how to inform the user on unauthorized sign up requests. Right now we just inform the user about it by using the generic server error dialog. This information would need to be improved.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/348

Comment 2

[Mónica UX/UI]

Attachment: UXPin-Loop_V1.1_No_Connection-FxA-Expired.pdf

This is the WF + Spec.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Screenshot

Monica, would you mind to have a look at how the new screen looks please? The string has changed a bit. I hope you don't mind we to take this new string. Please, let us know. Thanks!

Comment 4

[Antonio Manuel Amaya Calvo (:amac)]

Comment on attachment 8530936 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/348

I left a comment on Github. The log should be an error, and unconditional IMHO (since that's something that most definitely should never come up on the normal life of the app). Other than that, it looks great to me, thank you!

Change that (or not if you believe it's better behind a debug flag) and land it when you want.

Comment 5

[Mónica UX/UI]

Comment on attachment 8532015 [details]
Screenshot

If we add "Please try logging in again"..
I would change the buttons: [Ok] [Retry], :)

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6e9a7ecd1406b7089d34769bcbfad918ca2ffaf8

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: [1.1] Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/361

1.1. patch. Keeping r=amac

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Landed on 1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/4212078dd18628028661e7cc7775924d718630e8