1097088 - Write test Battery Turn on Automatically options

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

Settings] Battery Turn on Automatically options

    Go to Settings and select Battery option

    You see Turn on Automatically in Power Save Mode section

    Select Turn on Automatically drop-down

    List should appear and next options should be available: - 5% battery left - 15 % battery left - 25 % battery left - Never And one buttons: OK

    Select one of the options and then OK button

    Then Power Save Mode should turn on at that battery level



https://moztrap.mozilla.org/manage/case/1406/

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

Comment 2

[Viorela Ioia [:viorela]]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

Looks good, I just added a few comments

Comment 3

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

Agreed with Viorela. I left some questions on the PR.

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

Please address the comments from the PR.

Comment 5

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

The matching pattern might be a problem in the current state.

Comment 6

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

I think you made some changes in the wrong file (tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/language.py).

Comment 7

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8521492 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26073

LGTM!

Merge in master: https://github.com/mozilla-b2g/gaia/commit/3cf73f8294d5e0ee103291eb6cb03ea6e51ba086