a few small protocol.js.md fixes

RESOLVED FIXED in Firefox 36

Status

RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: jlong, Assigned: jlong)

Tracking

unspecified
Firefox 36
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
The docs for protocol.js say that a Front takes a client and the form `{ actorID: <id> }` but it should just be actor. Also a few places need 4 spaces not 2.
(Assignee)

Comment 1

4 years ago
Created attachment 8520711 [details] [diff] [review]
1097107.patch
(Assignee)

Comment 2

4 years ago
Comment on attachment 8520711 [details] [diff] [review]
1097107.patch

Nick you were the last one to touch this :p Not sure this really even needs to be reviewed though, it's a tiny change
Attachment #8520711 - Flags: review?(nfitzgerald)
Attachment #8520711 - Flags: review?(nfitzgerald) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

4 years ago
Created attachment 8520921 [details] [diff] [review]
1097107.patch
Attachment #8520711 - Attachment is obsolete: true
Hi, could you provide a try link, thanks!
Assignee: nobody → jlong
Flags: needinfo?(jlong)
(Assignee)

Comment 5

4 years ago
(In reply to Carsten Book [:Tomcat] from comment #4)
> Hi, could you provide a try link, thanks!

If you look at the patch, it's literally just a few changes to a markdown file... No executable code at all. Should I really use try?
Flags: needinfo?(jlong)
No need in this case. However, given that it's our default policy and parsing through every patch of every checkin-needed bug doesn't really scale (how many do you think we do daily?), a brief comment at the time of the request like you gave in comment 5 would have worked.

https://hg.mozilla.org/integration/mozilla-inbound/rev/92827522deee
Keywords: checkin-needed
(Assignee)

Comment 7

4 years ago
Sounds good, will do next time, thanks!
https://hg.mozilla.org/mozilla-central/rev/92827522deee
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Flags: qe-verify-

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.