Closed Bug 1097107 Opened 7 years ago Closed 7 years ago

a few small protocol.js.md fixes

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jlong, Assigned: jlong)

Details

Attachments

(1 file, 1 obsolete file)

The docs for protocol.js say that a Front takes a client and the form `{ actorID: <id> }` but it should just be actor. Also a few places need 4 spaces not 2.
Attached patch 1097107.patch (obsolete) — Splinter Review
Comment on attachment 8520711 [details] [diff] [review]
1097107.patch

Nick you were the last one to touch this :p Not sure this really even needs to be reviewed though, it's a tiny change
Attachment #8520711 - Flags: review?(nfitzgerald)
Attachment #8520711 - Flags: review?(nfitzgerald) → review+
Keywords: checkin-needed
Attached patch 1097107.patchSplinter Review
Attachment #8520711 - Attachment is obsolete: true
Hi, could you provide a try link, thanks!
Assignee: nobody → jlong
Flags: needinfo?(jlong)
(In reply to Carsten Book [:Tomcat] from comment #4)
> Hi, could you provide a try link, thanks!

If you look at the patch, it's literally just a few changes to a markdown file... No executable code at all. Should I really use try?
Flags: needinfo?(jlong)
No need in this case. However, given that it's our default policy and parsing through every patch of every checkin-needed bug doesn't really scale (how many do you think we do daily?), a brief comment at the time of the request like you gave in comment 5 would have worked.

https://hg.mozilla.org/integration/mozilla-inbound/rev/92827522deee
Keywords: checkin-needed
Sounds good, will do next time, thanks!
https://hg.mozilla.org/mozilla-central/rev/92827522deee
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Flags: qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.