1097107 - a few small protocol.js.md fixes

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[James Long (:jlongster)]

The docs for protocol.js say that a Front takes a client and the form `{ actorID: <id> }` but it should just be actor. Also a few places need 4 spaces not 2.

Comment 1

[James Long (:jlongster)]

Attachment: 1097107.patch

Comment 2

[James Long (:jlongster)]

Comment on attachment 8520711 [details] [diff] [review]
1097107.patch

Nick you were the last one to touch this :p Not sure this really even needs to be reviewed though, it's a tiny change

Comment 3

[James Long (:jlongster)]

Attachment: 1097107.patch

Comment 4

[Carsten Book [:Tomcat]]

Hi, could you provide a try link, thanks!

Comment 5

[James Long (:jlongster)]

(In reply to Carsten Book [:Tomcat] from comment #4)
> Hi, could you provide a try link, thanks!

If you look at the patch, it's literally just a few changes to a markdown file... No executable code at all. Should I really use try?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

No need in this case. However, given that it's our default policy and parsing through every patch of every checkin-needed bug doesn't really scale (how many do you think we do daily?), a brief comment at the time of the request like you gave in comment 5 would have worked.

https://hg.mozilla.org/integration/mozilla-inbound/rev/92827522deee

Comment 7

[James Long (:jlongster)]

Sounds good, will do next time, thanks!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/92827522deee