1097405 - Clean up imgStatusTracker's Difference APIs

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Right now code that wants to use imgStatusTracker to send notifications has to correctly call imgStatusTracker::Difference (in some cases at least), imgStatusTracker::ApplyDifference, and finally imgStatusTracker::SyncNotifyDifference. We should simplify this API. All that's really required is:

- Difference. Only RasterImage::FinishedSomeDecoding needs this, to support the loop that lets us avoid recursive notifications. It should never produce incorrect results to *not* all Difference before SyncNotifyDifference, as it can now.

- SyncNotifyDifference. Internally, this method should call both Difference and ApplyDifference (or really, just inline ApplyDifference, since it's trivial now).

Since we never need to call ApplyDifference independently from SyncNotifyDifference, we'll remove that method from the API totally.

Making this change will let us send notifications in two or three lines of simple, easy-to-understand code. Later refactorings will get this down to one line.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Clean up imgStatusTracker's Difference APIs

Here's the patch.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Try job here:

https://tbpl.mozilla.org/?tree=Try&rev=b141081f2926

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a3e7bca8051

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9a3e7bca8051