1097413 - Replace hard-coded version numbers in GLFeature

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

Symbolic constants kGLESVersion2 and kGLESVersion3.

Comment 1

[Kelsey Gilbert [:jgilbert]]

I don't know how necessary this is. If we do this, we should also convert the desktop versions, I think.

Comment 2

[u480271]

It's not necessary at all, but it's an itch that I scratched. Updating desktop versions is fair.

Comment 3

[u480271]

Attachment: Symbolic constants kGLESVersion2 and kGLESVersion3

GLES only part.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8524360 [details] [diff] [review]
Symbolic constants kGLESVersion2 and kGLESVersion3

Review of attachment 8524360 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextFeatures.cpp
@@ +22,5 @@
>  // ARB_ES3_compatibility is natively supported in OpenGL 4.3.
>  static const unsigned int kGLCoreVersionForES3Compat = 430;
>  
> +static const unsigned int kGLESVersion2 = 200;
> +static const unsigned int kGLESVersion3 = 300;

This would be better as a strong enum, such as GLESVersion::ES2/ES3/ES3_1

Comment 5

[u480271]

Attachment: Symbolic constants kGLESVersion2 and kGLESVersion3

Updated to use enum for constants and extended to GL versions too.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8525823 [details] [diff] [review]
Symbolic constants kGLESVersion2 and kGLESVersion3

Review of attachment 8525823 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextFeatures.cpp
@@ +639,3 @@
>      }
>  
> +    return (uint32_t) featureInfo.mOpenGLVersion;

Type mismatch with enum type.

Comment 7

[u480271]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da9f14c58aa5

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da9f14c58aa5