Closed Bug 1097413 Opened 6 years ago Closed 5 years ago

Replace hard-coded version numbers in GLFeature

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: djg, Assigned: djg)

References

Details

Attachments

(1 file, 1 obsolete file)

Symbolic constants kGLESVersion2 and kGLESVersion3.
I don't know how necessary this is. If we do this, we should also convert the desktop versions, I think.
It's not necessary at all, but it's an itch that I scratched. Updating desktop versions is fair.
GLES only part.
Attachment #8524360 - Flags: feedback?(jgilbert)
Comment on attachment 8524360 [details] [diff] [review]
Symbolic constants kGLESVersion2 and kGLESVersion3

Review of attachment 8524360 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextFeatures.cpp
@@ +22,5 @@
>  // ARB_ES3_compatibility is natively supported in OpenGL 4.3.
>  static const unsigned int kGLCoreVersionForES3Compat = 430;
>  
> +static const unsigned int kGLESVersion2 = 200;
> +static const unsigned int kGLESVersion3 = 300;

This would be better as a strong enum, such as GLESVersion::ES2/ES3/ES3_1
Attachment #8524360 - Flags: feedback?(jgilbert) → feedback+
Updated to use enum for constants and extended to GL versions too.
Attachment #8525823 - Flags: review?(jgilbert)
Attachment #8524360 - Attachment is obsolete: true
Comment on attachment 8525823 [details] [diff] [review]
Symbolic constants kGLESVersion2 and kGLESVersion3

Review of attachment 8525823 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextFeatures.cpp
@@ +639,3 @@
>      }
>  
> +    return (uint32_t) featureInfo.mOpenGLVersion;

Type mismatch with enum type.
Attachment #8525823 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/da9f14c58aa5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.