Closed Bug 1097488 Opened 10 years ago Closed 10 years ago

Add CSS_PROPERTY_ALWAYS_ENABLED_IN_UA_SHEETS for object-fit & object-position

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Bug 1065766 added a rule to html.css that uses the pref-controlled property "object-fit". (which we'll start relying on once bug 624647 lands.) Bug 624647 will be adding another related rule, to make "object-fit" & "object-position" inherit from <video> to its poster frame.

For these rules to be honored, we need to add the flag CSS_PROPERTY_ALWAYS_ENABLED_IN_UA_SHEETS to object-fit & object-position.

(Moreover, with that fixed, we can drop the "@supports" condition that's currently guarding the 'object-fit' rule in html.css, since that condition will no longer be able to fail.)
Attached patch fix v1Splinter Review
Attachment #8521163 - Flags: review?(cam)
Comment on attachment 8521163 [details] [diff] [review]
fix v1

Looks good.
Attachment #8521163 - Flags: review?(cam) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/f837d5422249
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: