1097543 - advanced settings in firefox developer use system's font color

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Vanadar]

Attachment: firefox-developers-advancedSettings.png

User Agent: Mozilla/5.0 (X11; Linux i686; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141111004002

Steps to reproduce:

I use a dark theme on KDE which set the font color to white.

i download the new Firefox Developer Edition, start it, then go to about:preferences#advanced


Actual results:

the text is in white which makes it very hard to read (see firefox-developers-advancedSettings.png)


Expected results:

the text should have been black (or the page should not set a background) like in about:preferences#security

Comment 1

[:Gijs (he/him)]

Note to self: use Adwaita-dark from http://askubuntu.com/questions/454372/dark-gtk-theme-for-ubuntu-14-04 to reproduce (the global dark theme and various other things I'd already installed didn't do the trick).

Jared, I don't want to add stuff to ship-in-content-prefs right now because you just triaged it, but I do think we should fix this before shipping...

In part because I can't figure out why this is happening, fwiw - the checkboxes in the security and advanced pane ought to be pretty similar, and I don't understand why the color isn't being applied in the same way. Maybe it's the tabpanel/tabbox, or something? :-\

Comment 2

[:Gijs (he/him)]

Attachment: tabpanel style should also override color because windows/linux re-set the color to -moz-dialogtext there,

Hah, sometimes writing it down makes everything clear. What's different between advanced prefs and all the other prefs? That's right, the tabpanels. Which get their color re-set on both Windows and Linux (so this is probably reproducible on dark high contrast themes on Windows, although I've not tested this). Fix is trivial, namely copy the color declaration there, too. Tested with style editor on my Linux VM.

Comment 3

[:Gijs (he/him)]

Specifically, see:

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/tabbox.css#21
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/faststripe/global/tabbox.css#20
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/tabbox.css#21

(OS X doesn't do this)

Comment 4

[:Gijs (he/him)]

Marco, can you add this? :-)

Comment 5

[Dão Gottwald [::dao]]

Comment on attachment 8522177 [details] [diff] [review]
tabpanel style should also override color because windows/linux re-set the color to -moz-dialogtext there,

>--- a/toolkit/themes/shared/in-content/common.inc.css
>+++ b/toolkit/themes/shared/in-content/common.inc.css
>@@ -70,20 +70,21 @@ xul|groupbox xul|label {
> 
> /* tabpanels and tabs */
> 
> xul|tabpanels {
>   -moz-appearance: none;
>   font-size: 1.25rem;
>   line-height: 22px;
>   border: none;
>   padding: 0;
>   background-color: transparent;
>+  color: #424e5a;

color: inherit;

r=me with that fixed

Comment 6

[Marco Mucci [:MarcoM]]

Added to IT 36.3

Comment 7

[:Gijs (he/him)]

w/ color: inherit;

remote:   https://hg.mozilla.org/integration/fx-team/rev/20b670ffa014

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20b670ffa014