1097550 - System dictionaries with underscore separator are ignored when trying to find dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Jan Horak [:jhorak]]

On some Linux distributions (like Fedora) dictionaries installed system-wide are using underscore as separator instead of dash. This breaks calling nsStyleUtil::DashMatchCompare in nsEditorSpellCheck::SetCurrentDictionary and nsEditorSpellCheck::DictionaryFetched and results in picking the first dictionary from dictionary list as fallback.

To fix this we need to replace underscore with dash when calling nsStyleUtil::DashMatchCompare.

Comment 1

[Jan Horak [:jhorak]]

Attachment: patch v1

Comment 2

[Jan Horak [:jhorak]]

Attachment: patch v2

Fixed comment in patch.
Relevant try run: 
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=eb49df4dcb90&resultStatus=testfailed&resultStatus=busted&resultStatus=exception&isClassified=false

Comment 3

[(no longer active)]

I imagine this is an alternative fix for the issue in bug 992118 comment 20, right?

Comment 4

[(no longer active)]

Comment on attachment 8521271 [details] [diff] [review]
patch v2

Review of attachment 8521271 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/nsEditorSpellCheck.cpp
@@ +619,5 @@
>        langCode.Assign(Substring(aDictionary, 0, dashIdx));
>      } else {
>        langCode.Assign(aDictionary);
>      }
> +    if (mPreferredLang.IsEmpty() || 

Nit: please remove the trailing space!

Comment 5

[Jan Horak [:jhorak]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> I imagine this is an alternative fix for the issue in bug 992118 comment 20,
> right?

Yes, exactly.

Comment 6

[Jan Horak [:jhorak]]

Attachment: patch v3

Fixed nits.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/741e6ee7e514

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/741e6ee7e514