Closed Bug 1097556 Opened 5 years ago Closed 5 years ago

Build fails with cs-qwerty

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: timdream)

References

Details

(Keywords: regression)

This happened after a |rm -rf objdir-gecko && make -C gaia/ clean really-clean| followed by a build.sh ; Nexus S with master from now.

> Exception: TypeError: Problem with keyboard layout "cs-qwerty" in GAIA_KEYBOARD_LAYOUTS
> win.Keyboards[layoutName] is undefined
> getLayoutDetails@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//keyboard-config.js:115:9
> getLayouts/layouts<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//keyboard-config.js:89:14
> getLayouts@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//keyboard-config.js:81:17
> copyLayoutsAndResources@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//keyboard-config.js:22:17
> KeyboardAppBuilder.prototype.copyLayouts@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//build.js:112:1
> KeyboardAppBuilder.prototype.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//build.js:150:3
> exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/apps/keyboard/build//build.js:158:4
> exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/build/build-app.js:9:3
> buildApps/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/build/app.js:71:9
> buildApps@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/build/app.js:55:3
> exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/alex/codaz/B2G/gaia/build/app.js:111:3
> CommonjsRunner.prototype.run@/home/alex/codaz/B2G/gaia/build/xpcshell-commonjs.js:166:5
> run@/home/alex/codaz/B2G/gaia/build/xpcshell-commonjs.js:181:3
> @-e:1:1

My .userconfig enables all keyboard that we have:
> export GAIA_KEYBOARD_LAYOUTS="$((find gaia/apps/keyboard/js/layouts/*.js | sed -e 's|gaia/apps/keyboard/js/layouts/||g' -e 's/\.js$//g') | tr -s '\r\n' ',' | sed -e 's/,$//g')"

Which gives:
> ar,bg-BDS,bg-Pho-Ban,bg-Pho-Trad,bn-Avro,bn-Probhat,bs,ca,cs,cs-qwerty,da,de,dz-BT,el,en-Colemak,en-Dvorak,en,en-Neo,eo,es-Americas,es,eu,ff,fr-CA,fr-CH,fr-Dvorak-bepo,fr,ga,gd,gl,gv,he,hi,hr,hu,it,jp-kanji,ko,lt,lv,mk,my,nb,nl,pl,pt-BR,pt-PT,ro,ru,sk,sq,sr-Cyrl,sr-Latn,sv,ta,tr-F,tr-Q,vi-Qwerty,vi-Telex,vi-Typewriter,zh-Hans-Handwriting,zh-Hans-Pinyin,zh-Hant-Zhuyin
Blocks: 1096057
Matej, this does not work.
Flags: needinfo?(mcepl)
Ah, my bad. The file should have attach itself on |Keyboards| with different name here:

https://github.com/mozilla-b2g/gaia/commit/b6ae1d6946f0ceeea4855f9742117ef64696de43

I'll push a follow-up fix right now.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(mcepl)
master: https://github.com/timdream/gaia/commit/6a840cd1f719b325b48ac341496bd757c0dbb8d0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.