MozReview Request: Bug 1097597 - Check if there is a Loop toolbarbutton node in updateToolbarState. r=Standard8
38 bytes, text/x-review-board-request
User Agent: Mozilla/5.0 (Windows NT 6.2; rv:36.0) Gecko/20100101 Firefox/36.0 Build ID: 20141111030203 Steps to reproduce: Adding the following user_pref("loop.enabled", false); to the prefs.js on a clean/new profile (or manually setting this preference to false via the about:config on any profile). Actual results: The about:customize page no longer presents the user with any customization options, the page render exactly like about:blank. Expected results: The about:customize should continue to work without any issues after disabling Loop.
Status: UNCONFIRMED → NEW
Component: Untriaged → Client
Ever confirmed: true
OS: Windows 8 → All
Product: Firefox → Loop
QA Contact: anthony.s.hughes
Hardware: x86 → All
Version: 36 Branch → unspecified
This also breaks the browser console and the rest of devtools. I have no idea how to get loop bugs prioritized, so I'm just going to needinfo someone. Mark, can you help?
Severity: normal → blocker
Summary: Disabling Loop renders about:customize blank → Disabling Loop breaks the world
Hi Gijs, setting the "blocking-loop" flag to the release you believe this blocks is the best way to get a bug prioritized. If it's a blocker/critical bug, doing a needinfo to me (mreavy@mozilla), Shell (email@example.com) and/or Mark is a good idea. I'm the eng mananger of Hello/Loop, Mark is tech lead, and Shell is our EPM. My testing patches Mark's. Fx34 is unaffected for me. My testing indicates that it's also related to the throttling code -- at least for Fx35. The throttling code in Fx34, Fx35, and fx36 is quite different. I'm marking this as Fx35+. Unfortunately, Mike has been out with a hand injury, but I'll needinfo him and ask Matt and/or Jaws to take a look at this. Thanks for flagging this! Matt -- Would you have a chance to look at this today? Mike -- Any ideas what's going wrong?
backlog: Fx35? → Fx35+
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 36.3
Points: --- → 3
"patches" should say "matches" :-) (My testing matches Mark's.)
/r/497 - Bug 1097597 - Check if there is a Loop toolbarbutton node in updateToolbarState. r=Standard8 Pull down this commit: hg pull review -r 9fe37f5753287a3d72cdbe06af68a65ffefab0b1
This seems to work for Nightly. I couldn't reproduce just having an issue with customize mode as the rest of the browser would already be broken when about:customizing was broken.
I would write a test for the pref change but the pref doesn't take effect until after a restart. Do you want me to simulate this state by deleting the node?
(In reply to Matthew N. [:MattN] (UTC+1 until Nov. 22) from comment #7) > This seems to work for Nightly. I couldn't reproduce just having an issue > with customize mode as the rest of the browser would already be broken when > about:customizing was broken. Matt -- Can you verify that your fix fixes both Nightly (Fx36) and Aurora (Fx35)? It's possible that the breakage is a little different since the throttling code for each is different. Also, can you verify that your fix now allows the user to bring up the browser console on both? (That was also failing for me due to this bug -- on both Nightly and Aurora.) Thanks!
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #9) > (In reply to Matthew N. [:MattN] (UTC+1 until Nov. 22) from comment #7) > > This seems to work for Nightly. I couldn't reproduce just having an issue > > with customize mode as the rest of the browser would already be broken when > > about:customizing was broken. > > Matt -- Can you verify that your fix fixes both Nightly (Fx36) and Aurora > (Fx35)? The patch applies cleanly and seems to fix Fx35 too. > Also, can you verify that your fix > now allows the user to bring up the browser console on both? Yes, it does fix this.
Attachment #8521366 - Flags: review?(standard8) → review+
https://reviewboard.mozilla.org/r/495/#review239 Looks good.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified fixed 36.0a2 (2014-12-17), 35b4 Win 7. Note the "[CustomizableUI]" "Custom widget with id loop-button-throttled does not return a valid node" error is still present.
You need to log in before you can comment on or make changes to this bug.