1097682 - Test failure 'Unknown property - identity.mixed_display_loaded' in /testSecurity/testMixedContentPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Module:    /testSecurity/testMixedContentPage.js
Test:      testMixedContentPage    
Failure:   Unknown property - identity.mixed_display_loaded
Branches:  Nightly
Platforms: All

Reports:
http://mozmill-daily.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-11-05&to=2014-11-12&test=%2FtestSecurity%2FtestMixedContentPage.js&func=testMixedContentPage

Comment 1

[Andreea Matei [:AndreeaMatei]]

The property might have changed, we need to find that changeset and update our test if needed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Simply look out for the property file and check its revisions. That might be faster to find if it is a property name change.

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

The property name was changed from identity.mixed_display_loaded to identity.mixed_active_loaded2

http://hg.mozilla.org/mozilla-central/diff/fa8605750b68/browser/locales/en-US/chrome/browser/browser.properties

Comment 4

[Andrei Eftimie]

The actual regressor is bug 1093595:
http://hg.mozilla.org/mozilla-central/rev/beda2bdc1fe1

Comment 5

[Andrei Eftimie]

Attachment: fix.patch

And here is the fix.

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8522750 [details] [diff] [review]
fix.patch

Review of attachment 8522750 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, thanks for the quick fix!

Comment 7

[Andrei Eftimie]

https://hg.mozilla.org/qa/mozmill-tests/rev/c202ab5d4f74 (default)