1097700 - Test failure 'Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.remove]' in /testAddons/testInstallUninstallSoftBlocklistedExtension.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Module:    /testAddons/testInstallUninstallSoftBlocklistedExtension.js
Test:      setupModule, teardownModule    
Failure:   Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.remove]
Branches:  Nightly (36.0a1), Aurora (35.0a2)
Platforms: all Windows
Locales: en_US, de, ru, zh-CN

Reports:
* setupModule: http://mozmill-daily.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=All&from=2014-07-01&to=2014-11-12&test=%2FtestAddons%2FtestInstallUninstallSoftBlocklistedExtension.js&func=setupModule
* teardownModule: http://mozmill-daily.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=All&from=2014-11-05&to=2014-11-12&test=%2FtestAddons%2FtestInstallUninstallSoftBlocklistedExtension.js&func=teardownModule

Comment 1

[Andrei Eftimie]

I'll look into this since it's from the just landed bug 987612.

Comment 2

[Andrei Eftimie]

The code was made to ignore if the file does not exist:
http://hg.mozilla.org/qa/mozmill-tests/file/237610e3006b/lib/files.js#l96

The error we are expecting is "NS_ERROR_FILE_TARGET_DOES_NOT_EXIST".
What we see here is "NS_ERROR_FILE_NOT_FOUND" which might be a difference between *nix and win systems.

If this is indeed the case, the fix will be to also ignore this error (and by now it certainly looks that way). This should be easily testable with lib/tests/test_files.js

Comment 3

[Andrei Eftimie]

Attachment: fix.patch

Simple fix. The problem is indeed the one I've elaborated in the previous comment.
Windows gives a different error message when attempting to remove a file that doesn't exist. We not take this into account as well.

And this can be tested with lib/tests/test_files.js

Comment 4

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8521464 [details] [diff] [review]
fix.patch

Review of attachment 8521464 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Andrei Eftimie]

Landed:
https://hg.mozilla.org/qa/mozmill-tests/rev/f4d289b349c5 (default)
https://hg.mozilla.org/qa/mozmill-tests/rev/b350a4d53e46 (mozilla-aurora)

I'll need to make sure to include this fix when backporting bug 987612 to beta.