Top sites trigger external requests during tests

RESOLVED FIXED in 2.1 S9 (21Nov)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: daleharvey, Assigned: daleharvey)

Tracking

unspecified
2.1 S9 (21Nov)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Assignee: nobody → dale
Blocks: 1030045
(Assignee)

Comment 2

4 years ago
We loose a test in this, we would need the ability to define top sites in the test setup which would be a whole other bunch of work, can file as a follow up.

But we gain 2 more tests :) they were disabled waiting for marionette js fixes to land
Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

Re-triggered gaia-try to get results, and it looks like a few of the tests are failing, so I'm not going to leave my R+ quite yet. The code looks good to land to me though. Address the test failures and re-flag me. Thanks!
Attachment #8521472 - Flags: review?(kgrandon)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

The failures were the tests I enabled, investigating why they are failing but no need to block this, the red is permafail that will go green with a new build
Attachment #8521472 - Flags: review?(kgrandon)
Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

Looks good to me, thanks!
Attachment #8521472 - Flags: review?(kgrandon) → review+
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in before you can comment on or make changes to this bug.