1097726 - Top sites trigger external requests during tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/26071

Comment 2

[Dale Harvey (:daleharvey)]

We loose a test in this, we would need the ability to define top sites in the test setup which would be a whole other bunch of work, can file as a follow up.

But we gain 2 more tests :) they were disabled waiting for marionette js fixes to land

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

Re-triggered gaia-try to get results, and it looks like a few of the tests are failing, so I'm not going to leave my R+ quite yet. The code looks good to land to me though. Address the test failures and re-flag me. Thanks!

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

The failures were the tests I enabled, investigating why they are failing but no need to block this, the red is permafail that will go green with a new build

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8521472 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26071

Looks good to me, thanks!

Comment 6

[Dale Harvey (:daleharvey)]

Green - https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=fc36009fe5fd

https://github.com/mozilla-b2g/gaia/commit/3ae38e3ec37eb0f455f3fd997eed0c5f3cb7c109