The default bug view has changed. See this FAQ.

Legal-docs-based pages should not rely on active tags in .lang files

RESOLVED FIXED

Status

www.mozilla.org
Bedrock
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: pmac, Assigned: kohei)

Tracking

(Blocks: 1 bug)

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1611395] )

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Currently we're having to manage the active languages for the privacy policies etc. (under https://www.mozilla.org/privacy/) with "active" tags in .lang files for the templates. But really we should be activating these locales based on which language versions of the docs are available in the legal-docs repo.

It's possible we're happy with having more control over which languages are active, in which case we can WONTFIX this. But allowing the legal-docs authors to control this seems most appropriate.
I'm meeting with Peiying on Monday to discuss.  More after that.  Thx.
(Assignee)

Comment 2

2 years ago
WIP: https://github.com/kyoshino/bedrock/compare/bug-1097785-legal-docs-lang
(Assignee)

Updated

2 years ago
Blocks: 775269
Let's move forward with Kohei's fix to allow Legal-docs authors to have more control.

Kohei - when it is ready, will you let me know what legal-docs authors will need to change in their process?
Whiteboard: [kb=1611395]
(Assignee)

Comment 4

2 years ago
I'll finalize my pull request this week. The remaining issue is the page's language switcher.

Once my PR is landed, locales will be automatically activated once localized legal-docs are merged to Bedrock, without any extra steps by the authors :)
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Component: Pages & Content → Bedrock
(Assignee)

Comment 5

2 years ago
Created attachment 8547868 [details] [review]
pull request

Comment 6

2 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/095784321ba756d71157ced2cc0f8191c472ef85
Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files

https://github.com/mozilla/bedrock/commit/75db96a7a25f36471116fec9ea89e56f2cd065a3
Merge pull request #2644 from kyoshino/bug-1097785-legal-docs-lang

Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Files removed from trunk in r137536, also taking the chance to make /privacy properly localizable.

Moved to stage in r137543 (together with other changes), waiting to test on www.allizom.org
(Assignee)

Comment 8

2 years ago
Thanks :flod!
(Assignee)

Updated

2 years ago
Depends on: 1165178
You need to log in before you can comment on or make changes to this bug.