1097785 - Legal-docs-based pages should not rely on active tags in .lang files

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Paul [:pmac] McLanahan]

Currently we're having to manage the active languages for the privacy policies etc. (under https://www.mozilla.org/privacy/) with "active" tags in .lang files for the templates. But really we should be activating these locales based on which language versions of the docs are available in the legal-docs repo.

It's possible we're happy with having more control over which languages are active, in which case we can WONTFIX this. But allowing the legal-docs authors to control this seems most appropriate.

Comment 1

[Jennifer Bertsch [:jbertsch]]

I'm meeting with Peiying on Monday to discuss.  More after that.  Thx.

Comment 2

[Kohei Yoshino [:kohei]]

WIP: https://github.com/kyoshino/bedrock/compare/bug-1097785-legal-docs-lang

Comment 3

[Jennifer Bertsch [:jbertsch]]

Let's move forward with Kohei's fix to allow Legal-docs authors to have more control.

Kohei - when it is ready, will you let me know what legal-docs authors will need to change in their process?

Comment 4

[Kohei Yoshino [:kohei]]

I'll finalize my pull request this week. The remaining issue is the page's language switcher.

Once my PR is landed, locales will be automatically activated once localized legal-docs are merged to Bedrock, without any extra steps by the authors :)

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/095784321ba756d71157ced2cc0f8191c472ef85
Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files

https://github.com/mozilla/bedrock/commit/75db96a7a25f36471116fec9ea89e56f2cd065a3
Merge pull request #2644 from kyoshino/bug-1097785-legal-docs-lang

Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files

Comment 7

[Francesco Lodolo [:flod]]

Files removed from trunk in r137536, also taking the chance to make /privacy properly localizable.

Moved to stage in r137543 (together with other changes), waiting to test on www.allizom.org

Comment 8

[Kohei Yoshino [:kohei]]

Thanks :flod!