1097824 - Call button briefly visible when using forget feature

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect)

Description

[Sam]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141106120505

Steps to reproduce:

Click on Forget last two hours


Actual results:

While forget is being executed, a call button is visible beside the forget buton


Expected results:

No call button should be visible

Comment 1

[Sam]

Attachment: Call button.jpg

Screen shot of call button

Comment 2

[Sam]

Attachment: Call button.jpg

Highlighted screen shot of call button

Comment 3

[:Gijs (he/him)]

(In reply to Sam from comment #1)
> Created attachment 8523649 [details]
> Call button.jpg
> 
> Screen shot of call button

Is this on the new clean window that opens, or on the old window? And at the point where it appears, does Firefox seem "hung" ?

standard8/mreavy: I expect this is in part due to perf issues with clearing data, but I actually would expect the loop stuff to be hidden by default and then shown when enabled, not the other way around... Is that something that could be fixed within Loop?

Comment 4

[Sam]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Sam from comment #1)
> > Created attachment 8523649 [details]
> > Call button.jpg
> > 
> > Screen shot of call button
> 
> Is this on the new clean window that opens, or on the old window? And at the
> point where it appears, does Firefox seem "hung" ?
This happens in between the old & new window. It does seem like a performance issue, this is not noticeable on another PC with 8GB RAM.

Comment 5

[:Gijs (he/him)]

(In reply to Sam from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > (In reply to Sam from comment #1)
> > > Created attachment 8523649 [details]
> > > Call button.jpg
> > > 
> > > Screen shot of call button
> > 
> > Is this on the new clean window that opens, or on the old window? And at the
> > point where it appears, does Firefox seem "hung" ?
> This happens in between the old & new window. It does seem like a
> performance issue, this is not noticeable on another PC with 8GB RAM.

Sorry for being dim, but I don't understand. Does the call button you see appear on the newly created window, or on the window from which you activated "forget" ? Or both? From the screenshot, it's clearly in a window - but the screenshot doesn't tell me which window that is.

Comment 6

[Sam]

Attachment: Screen capture video

(In reply to :Gijs Kruitbosch from comment #5)
> Sorry for being dim, but I don't understand. Does the call button you see
> appear on the newly created window, or on the window from which you
> activated "forget" ? Or both? From the screenshot, it's clearly in a window
> - but the screenshot doesn't tell me which window that is.

Here is a screen capture video (.avi). Watch closely for the call button to briefly appear between the 3s & 4s interval.

Comment 7

[u279076]

Paul, can you please try to reproduce this?

Comment 8

[Paul Silaghi, QA [:pauly]]

So, the problem is, after pressing the "Forget button", the call button appears in the new window and then quickly disappears.
Confirmed in FF 33.1.1 Win 7 x64.
Seems like it doesn't affect upper FF versions, since there Loop is enabled by default.

Comment 9

[:Gijs (he/him)]

(In reply to Paul Silaghi, QA [:pauly] from comment #8)
> So, the problem is, after pressing the "Forget button", the call button
> appears in the new window and then quickly disappears.
> Confirmed in FF 33.1.1 Win 7 x64.
> Seems like it doesn't affect upper FF versions, since there Loop is enabled
> by default.

You mean Firefox 34 is fine? Even if you set loop.disabled to true? (which, AIUI, will be the case for most profiles initially, with a gradual introduction and whatnot). In that case, it sounds like this is essentially WFM - we won't spin another 33.1 build for this, and 34 is barely more than a week or so away at this point.

Comment 10

[Paul Silaghi, QA [:pauly]]

(In reply to :Gijs Kruitbosch from comment #9)
> You mean Firefox 34 is fine? Even if you set loop.disabled to true?
I haven't tried this scenario initially.
But it seems it also doesn't reproduce with loop.enabled=FALSE, FF 34b10, 36.0a1 (2014-11-19) Win 7 x64.
IIRC, starting FF 34, Loop suffered a lot of changes, probably that's why it's not reproducible.