1097912 - can't run unit tests via `./bin/gaia-test`

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Updated to latest Nightly, and now I can't get the tests to run on today's gaia master. Nightly does open, but opens to a blank tab, and never loads the test server page.

Tried `make clean` and `make really-clean`, but it still seems busted.

The command line errors I see are:

JavaScript error: resource://gre/modules/WebappOSUtils.jsm, line 193: TypeError: aPossiblyBadFilenameString is undefined
!! Creating a dummy channel for test-agent.gaiamobile.org (no appInfo)
JavaScript error: chrome://global/content/browser-child.js, line 202: NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIWebNavigation.loadURI]

Complete command line output is at http://6a68.pastebin.mozilla.org/7271847

Comment 1

[Julien Wajsberg [:julienw]]

I've narrowed this to app:// being broken.

If you manually use http://test-agent.gaiamobile.org:8080, then it loads. You'll have some failed test because of this (some tests are assuming we run using app://) but at least you'll be able to run it.

Comment 2

[Julien Wajsberg [:julienw]]

And it's actually broken by e10s. If you disable e10s in the settings, it works again.

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: github PR

Discussed with Alexandre, this comes from how we register the app:// protocol in httpd.js. We register it in the main process but not in the child process, and as a result this breaks when we run it in e10s.

Since running unit tests in Nightly will soon end in favor of Mulet, and because e10s is disabled in Mulet too, I'll just disable e10s for debug profiles.

Comment 4

[Alexandre Poirot [:ochameau] PTO, back May 4th]

Comment on attachment 8522207 [details] [review]
github PR

Yes. I don't think we really care about running tabs OOP...
We care about running apps, opened within the system app OOP.

Comment 5

[Julien Wajsberg [:julienw]]

(Waiting for a try run before landing)

Comment 6

[Julien Wajsberg [:julienw]]

master: 7dd98868e296076621b71ff86fce2eb419369842

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

After pulling gaia updates and doing a `make really-clean`, tests are fixed for me.

Thanks for jumping on this bug so quickly ^_^

Comment 8

[Julien Wajsberg [:julienw]]

FYI it broke again in bug 1104198; if you use disable OOP manually or use Mulet it should work.