1097962 - [costcontrol] costcontrol-test/unit/fte_test.js each test with JavaScript Error message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141106030201

Steps to reproduce:

each test generate Error in the console
FTE for non supported SIM 
    ✓ [costcontrol-test/unit/fte_test.js] DATA_USAGE_ONLY mode initialized correctly (45ms)
JavaScript error: app://costcontrol.gaiamobile.org/common/vendor/test-agent/test-agent.js, line 530: Error: Could not parse json: '[object: Object]'"



Expected results:

I suggests - problem in the function setupApplicationMode 

when i change test-agent.js - more readable Error message
Responder.parse = function parse(json) {
    var data;
    try {
      data = (json.forEach) ? json : JSON.parse(json);
    } catch (e) {
      var output = '';
      for (var key in json) {
        if (json.hasOwnProperty(key)) {
          output += key + ': ' + json[key]+'; ';
        }  
      }
      throw new Error("Could not parse json: '" + JSON.stringify(json) + '"');
    }

    return {event: data[0], data: data[1]};
  };

then i see Error: Could not parse json: '{"type":"fte_ready","data":""}"

?? Message sended after test ended ??

Comment 1

[sv99]

Attachment: Link to PR

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8521677 [details] [review]
Link to PR

Nice catch! Please correct the nit on GitHub.

Comment 3

[sv99]

Corrected

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/a710590a62889f0a9b3484e0b22ab4d3abf638c5