Closed Bug 1098022 Opened 5 years ago Closed 5 years ago

Videos that don't start at 0 are treated as a new segment by TimestampsFuzzyEqual

Categories

(Core :: Audio/Video, defect)

29 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch initial-timestamp (obsolete) — Splinter Review
We should initialize mLastEndTimestamp to -1 to be able to differentiate between 'no previous data' and an actual time of 0.
Attachment #8521782 - Flags: review?(ajones)
We need an Option or Maybe type...
Comment on attachment 8521782 [details] [diff] [review]
initial-timestamp

Review of attachment 8521782 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not super keen on -1 as the universal sentinel and would tend to use a constant like NO_TIME=-1 which is slightly less horrible. We may be able to just check if the Decoder actually has any data in it instead. I'm OK with landing it as-is if there isn't a way to check TrackBuffer being empty.
Attachment #8521782 - Flags: review?(ajones) → review+
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #3)
> Comment on attachment 8521782 [details] [diff] [review]
> initial-timestamp
> 
> Review of attachment 8521782 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not super keen on -1 as the universal sentinel and would tend to use a
> constant like NO_TIME=-1 which is slightly less horrible. We may be able to
> just check if the Decoder actually has any data in it instead. I'm OK with
> landing it as-is if there isn't a way to check TrackBuffer being empty.

Can we use mfbt/Maybe.h?
Attachment #8521782 - Attachment is obsolete: true
Attachment #8522608 - Flags: review?(ajones)
Attachment #8522608 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/b52b8019d49a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.