1098077 - Add support for a non-default about:config pref to disable the HTTPS requirement for FxA server URLs

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Chris Karlof [:ckarlof]]

Otherwise local dev testing with Sync is a PITA.

Comment 1

[Chris Karlof [:ckarlof]]

Attachment: 0001-Add-support-to-disable-HTTPS-requirement-for-FxA-loc.patch

Comment 2

[Chris Karlof [:ckarlof]]

Attachment: user.js

Comment 3

[Chris Karlof [:ckarlof]]

Attachment: 0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch

Comment 4

[Chris Karlof [:ckarlof]]

Attachment: user.js

Comment 5

[Chris Karlof [:ckarlof]]

https://tbpl.mozilla.org/?tree=Try&rev=44c263547130

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8535902 [details] [diff] [review]
0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch

Review of attachment 8535902 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/fxaccounts/FxAccounts.jsm
@@ +857,5 @@
>    },
>  
> +  _requireHttps: function() {
> +    let requireHttps = true;
> +    try {

I'd probably prefer the pref be named id.fxa.allowHttp and *not* be written to firefox.js, just to avoid the temptation of "power users" thinking it might be OK to toggle this.

If you feel strongly though, I'm OK with this - r+ either way (I don't really need to see a new patch if you take my suggestion - just ship it ;)

Comment 7

[Chris Karlof [:ckarlof]]

Arrggh. I guessed wrong. The old patch used have it as allowHttp, but I decided to change it for some reason.

Comment 8

[Chris Karlof [:ckarlof]]

Attachment: 0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch

r+ from markh carried over.

Comment 9

[Chris Karlof [:ckarlof]]

Attachment: user.js

Comment 10

[Chris Karlof [:ckarlof]]

Thanks Mark!

Comment 11

[Chris Karlof [:ckarlof]]

https://hg.mozilla.org/integration/fx-team/rev/cfff678a046d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfff678a046d