Add support for a non-default about:config pref to disable the HTTPS requirement for FxA server URLs

RESOLVED FIXED in Firefox 37

Status

()

Firefox
Firefox Accounts
RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: ckarlof, Assigned: ckarlof)

Tracking

Trunk
Firefox 37
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

4 years ago
Otherwise local dev testing with Sync is a PITA.
(Assignee)

Comment 1

4 years ago
Created attachment 8521890 [details] [diff] [review]
0001-Add-support-to-disable-HTTPS-requirement-for-FxA-loc.patch
(Assignee)

Comment 2

4 years ago
Created attachment 8521891 [details]
user.js
(Assignee)

Comment 3

3 years ago
Created attachment 8535902 [details] [diff] [review]
0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch
Attachment #8521890 - Attachment is obsolete: true
Attachment #8535902 - Flags: review?(mhammond)
(Assignee)

Comment 4

3 years ago
Created attachment 8535903 [details]
user.js
Attachment #8521891 - Attachment is obsolete: true
Comment on attachment 8535902 [details] [diff] [review]
0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch

Review of attachment 8535902 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/fxaccounts/FxAccounts.jsm
@@ +857,5 @@
>    },
>  
> +  _requireHttps: function() {
> +    let requireHttps = true;
> +    try {

I'd probably prefer the pref be named id.fxa.allowHttp and *not* be written to firefox.js, just to avoid the temptation of "power users" thinking it might be OK to toggle this.

If you feel strongly though, I'm OK with this - r+ either way (I don't really need to see a new patch if you take my suggestion - just ship it ;)
Attachment #8535902 - Flags: review?(mhammond) → review+
(Assignee)

Comment 7

3 years ago
Arrggh. I guessed wrong. The old patch used have it as allowHttp, but I decided to change it for some reason.
(Assignee)

Comment 8

3 years ago
Created attachment 8535924 [details] [diff] [review]
0001-Bug-1098077-Add-pref-to-disable-HTTPS-requirement-fo.patch

r+ from markh carried over.
Attachment #8535902 - Attachment is obsolete: true
Attachment #8535924 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8535926 [details]
user.js
Attachment #8535903 - Attachment is obsolete: true
(Assignee)

Comment 10

3 years ago
Thanks Mark!
(Assignee)

Updated

3 years ago
Assignee: nobody → ckarlof
QA Contact: kthiessen
https://hg.mozilla.org/mozilla-central/rev/cfff678a046d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
QA Contact: kthiessen

Updated

5 months ago
Product: Core → Firefox
Target Milestone: mozilla37 → Firefox 37
You need to log in before you can comment on or make changes to this bug.