Closed Bug 1098107 Opened 9 years ago Closed 9 years ago

Change the wait in AddNewNumber to avoid intermittent timeout with test_dialer_add_contact on b2gdesktop

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: jlorenzo)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Gaia PR
46 bytes, text/x-github-pull-request
viorela
: review+
RobertC
: review+
Details | Review 
15:38:23     INFO -  TEST-START | test_dialer_add_contact.py TestDialerAddContact.test_dialer_add_contact
15:38:52    ERROR -  TEST-UNEXPECTED-ERROR | test_dialer_add_contact.py TestDialerAddContact.test_dialer_add_contact | TimeoutException: TimeoutException: Timed out after 10.1 seconds
15:38:52     INFO -  Traceback (most recent call last):
15:38:52     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/marionette/marionette_test.py", line 267, in run
15:38:52     INFO -      testMethod()
15:38:52     INFO -    File "/builds/slave/talos-slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer_add_contact.py", line 34, in test_dialer_add_contact
15:38:52     INFO -      new_contact = add_new_number.tap_create_new_contact()
15:38:52     INFO -    File "/builds/slave/talos-slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/phone/regions/keypad.py", line 110, in tap_create_new_contact
15:38:52     INFO -      new_contact.switch_to_new_contact_form()
15:38:52     INFO -    File "/builds/slave/talos-slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py", line 185, in switch_to_new_contact_form
15:38:52     INFO -      Wait(self.marionette).until(lambda m: self.apps.displayed_app.src == self._src)
15:38:52     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/marionette/wait.py", line 143, in until
15:38:52     INFO -      cause=last_exc)
15:38:52     INFO -  TEST-INFO took 29198ms
Per the stacktraces, this seems to repro only on b2g_macosx64. I tried to repro on my device (30 times) and on this adhoc job[1] without success. I'll set up a Mac to see if I can repro there.

I discussed it offline with Zac, Dave Hunt and Viorela, it may be the wait in the init of AddNewNumber class. I'll investigate the issue.

[1] http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/363/console
Assignee: nobody → jlorenzo
QA Whiteboard: [fxosqa-auto-s5+][fxosqa-auto-points=4]
Component: Gaia::Dialer → Gaia::UI Tests
Summary: Intermittent test_dialer_add_contact.py TestDialerAddContact.test_dialer_add_contact | TimeoutException: TimeoutException: Timed out after 10.1 seconds → Change the wait in AddNewNumber to avoit intermittent timeout with test_dialer_add_contact on b2gdesktop
Summary: Change the wait in AddNewNumber to avoit intermittent timeout with test_dialer_add_contact on b2gdesktop → Change the wait in AddNewNumber to avoid intermittent timeout with test_dialer_add_contact on b2gdesktop
Attached file Gaia PR — 
You can see this try on treeherder before I squashed my commits: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9fe61766ed1b
Attachment #8529655 - Flags: review?(viorela.ioia)
Attachment #8529655 - Flags: review?(robert.chira)
Comment on attachment 8529655 [details] [review]
Gaia PR

r+
Attachment #8529655 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8529655 [details] [review]
Gaia PR

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/f55e53d5926a965b45505e25b0604bb9aef668f2

I will leave this bug open for a while to see if the issue was fixed.
Attachment #8529655 - Flags: review?(robert.chira) → review+
We had at least 12 TPBL failures a day. Now we've had no TBPL message for the last 23 hours. I mark this bug as resolved. If this issue occurs again, please reopen.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.